specify explicit encoding(UTF-8) for the calls in sconstruct and checkPot.py#13698
Merged
Merged
Conversation
5 tasks
Member
|
@feerrenrut - this is a small change but as I don't fully understand the current translation system I would like a second review |
1 similar comment
Member
|
@feerrenrut - this is a small change but as I don't fully understand the current translation system I would like a second review |
lukaszgo1
reviewed
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
As a change required by #13675
Description of how this pull request fixes the issue:
According to this comment by @lukaszgo1 in #13675
Because Python function opens the text files using the default ANSI code page on Windows and the ANSI code page on system (and on AppVeyor) cannot correctly decode utf-8 text.
To fix this we need to specify explicit encoding(UTF-8) for the calls in sconstruct and test/checkPot.py
Testing strategy:
Execute scons pot to test
Known issues with pull request:
None
Change log entries:
New features
Changes: specify explicit encoding for the calls in sconstruct and checkPot.py
Bug fixes
For Developers
Code Review Checklist: