Skip to content

Move exit dialog to submodule#13498

Merged
seanbudd merged 4 commits into
masterfrom
moveExitDialogToSubmodule
Mar 24, 2022
Merged

Move exit dialog to submodule#13498
seanbudd merged 4 commits into
masterfrom
moveExitDialogToSubmodule

Conversation

@seanbudd

@seanbudd seanbudd commented Mar 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

When working on #13488, the exitDialog was lengthened, and probably should be moved to its own submodule file.

Description of how this pull request fixes the issue:

Moves and lints ExitDialog and _ExitAction from gui.__init__ into gui.exit.

Testing strategy:

  • Review the move commit with git show ea52996ae9a3ae7a2a536d5298bce9d8595e24be --color-moved
  • Review linting manually git show ea2c04119
  • Review the CRLF change with git show 196b55dc8 --ignore-cr-at-eol
  • Run NVDA and opening the exit dialog
  • Ensure Disable logging in secure mode #13488 isn't reintroduced

Known issues with pull request:

None

Change log entries:

For Developers

- ``gui.quit`` has been deprecated for removal in 2023.1. (#13498)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

seanbudd added a commit that referenced this pull request Mar 17, 2022
@seanbudd
Lint source/gui/exit.py and fix imports (#13498)
fe0e846
@seanbudd seanbudd force-pushed the moveExitDialogToSubmodule branch from fb2e9cc to 467f814 Compare March 17, 2022 06:35
@seanbudd seanbudd marked this pull request as ready for review March 17, 2022 06:38
@seanbudd seanbudd requested a review from a team as a code owner March 17, 2022 06:38
@seanbudd seanbudd requested a review from michaelDCurran March 17, 2022 06:38
@AppVeyorBot

This comment was marked as outdated.

Sign in to view
@seanbudd seanbudd force-pushed the moveExitDialogToSubmodule branch from 467f814 to 196b55d Compare March 17, 2022 08:19
@AppVeyorBot

This comment was marked as outdated.

Sign in to view
@feerrenrut feerrenrut added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 18, 2022
@seanbudd seanbudd self-assigned this Mar 18, 2022
@seanbudd seanbudd requested review from feerrenrut and removed request for michaelDCurran March 18, 2022 06:19
feerrenrut
feerrenrut approved these changes Mar 22, 2022
View reviewed changes
Comment thread source/gui/exit.py
lukaszgo1
lukaszgo1 suggested changes Mar 22, 2022
View reviewed changes
Comment thread source/gui/exit.py Outdated
Comment thread source/gui/exit.py Outdated
@seanbudd seanbudd requested a review from feerrenrut March 23, 2022 00:36
@seanbudd seanbudd marked this pull request as draft March 23, 2022 00:36
@seanbudd seanbudd marked this pull request as ready for review March 23, 2022 02:16
feerrenrut
feerrenrut suggested changes Mar 23, 2022
View reviewed changes
Comment thread source/gui/__init__.py Outdated
Comment thread source/gui/exit.py Outdated
@seanbudd seanbudd requested a review from feerrenrut March 23, 2022 23:44
@seanbudd @lukaszgo1
mark gui.quit as deprecated for removal (#13498)
a840171 
Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
@seanbudd seanbudd force-pushed the moveExitDialogToSubmodule branch from f60dfb4 to a840171 Compare March 24, 2022 06:19
@seanbudd seanbudd merged commit 14a9499 into master Mar 24, 2022
@seanbudd seanbudd deleted the moveExitDialogToSubmodule branch March 24, 2022 06:50
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lukaszgo1 lukaszgo1 lukaszgo1 requested changes

@feerrenrut feerrenrut feerrenrut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seanbudd seanbudd

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2022.2

Development

Successfully merging this pull request may close these issues.

5 participants

@seanbudd @AppVeyorBot @feerrenrut @lukaszgo1 @nvaccessAuto