Link to issue number:

Fixes #11568
Partial fix for #12920

Summary of the issue:

Recent versions of Adobe Reader introduced a Protected Mode, where by the Adobe Acrobat process has less privileges and is sandboxed. This ensures that insecure PDFs do not have a chance to affect the rest of the Operating System.
By default Adobe Reader is configured to enter its Protected mode on start-up, and to set the 'isAppContainer' attribute on its process token.
There seems to be a bug however, either in Adobe Reader, the Windows OS, or NVDA (NV access and Adobe cannot be sure) that causes the Adobe Reader process to become unstable when NVDA tires to register IAccessible2. Specifically, the call to CoGetPSClsid seems to start making things unstable. The further call to CoRegisterPSClsid fails, and then eventually the process completely crashes randomly in places such as TSF initialization.
The upshot is that If Adobe Reader is started when NVDA is running, many errors are written to NVDA's log, and Adobe Reader closes straight away.

Description of how this pull request fixes the issue:

NVDAHelper's IAccessible2 registration code now checks if the process token has the 'IsAppContainer' attribute, and of so refuses to install IAccessible2 support.
Note that Adobe Reader itself does not require IAccessible2 to function.
Also, the 'IsAppContainer' is only set on very heavily sandboxed sitations, and is not the same as the app container that is used for Windows Desktop Bridge apps. Thus, refusing to install IAccessible2 into processes with the 'IsAppContainer' attribute has no other known side affects.

Testing strategy:

• Installed Adobe Reader 32 bit.
• With NVDA running, launched Adobe Reader 32 bit. Ensured that it did not close / crash.
• Ensured that errors were not written to the NVDA log.
• Repeated all the previous steps but this time with Adobe Reader 64 bit.
• Ensured that IAccessible2 support was still being registered in other processes E.g. Firefox, by compiling NvDAHelper with nvdaHelperLogLevel set to debug and looking at the log for the appropriate registration messages.

Known issues with pull request:

Note that this pr does not address the crashes in Adobe Reader 64 bit when trying to read a PDF. This is a very separate issue.

Change log entries:

New features
Changes
Bug fixes

• Adobe Reader no longer closes due to a crash on launch. (alpha builds: many error messages in the log when opening Adobe Reader #11568)

For Developers

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English