Revert "MS Word with UIA: use custom extensions to support line number, layout column number and section number"#13350
Merged
Conversation
5 tasks
michaelDCurran
added a commit
that referenced
this pull request
Feb 24, 2022
…Word via UIA, using UIA remote ops (#13387) This reintroduces the commits in pr #13283 which had been reverted in pr #13350. However it also addresses build issues. Summary of the issue: PR #13283 introduced support for reporting line/column/section numbers in Microsoft word via UI Automation, by using the UI Automation Remote Operations Library. However, this PR had to be reverted in #13350 as 1. UIA would not initialize properly in binary builds due to a missing manifest file. (Improper initialization of UIA during NVDA start #13347) 2. NVDA failed to build on Visual Studio 2022. Specifically when building the Remote Ops library with msbuild, midl would fail with an error about a system environment variable being missing. 3. NVDA could no longer be built on Windows 7. (Impossible to build NVDA after introduction of UIA remote library #13346) Description of how this pull request fixes the issue: This PR reintroduces all of the original changes, but: • setup.py now includes *.manifest files in the lib directory. • NVDA again now requires Visual Studio 2019. However, builds will not fail if a newer version of Visual Studio (E.g. 2022) is installed along side 2019. this is managed by setting MSVC_VERSION in scons before it looks for Visual Studio, so that it specifically selects VS 2019 (VC 14.2). Although building on Windows 7 could not be fixed, the readme now notes that only building on Windows 10 and higher is supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13283
Reverted due to #13346 and microsoft/microsoft-ui-uiautomation/#89