Skip to content

Windows 10 Calculator: give labels to history and memory list items#13213

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
josephsl:i11858calculatorMemoryAndHistoryItems
Jan 13, 2022
Merged

Windows 10 Calculator: give labels to history and memory list items#13213
seanbudd merged 4 commits into
nvaccess:masterfrom
josephsl:i11858calculatorMemoryAndHistoryItems

Conversation

@josephsl

@josephsl josephsl commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #11858

Summary of the issue:

In Windows 10 Calculator (10.2009 and later), there is no label for history and memory list items.

Description of how this pull request fixes the issue:

Children of list items do provide necesary components ror memory and history itemss, therefor3e set list item labels based on what the children says.

Testing strategy:

Manual testing:

  1. Open Calculator on Windows 10.
  2. Perform some calculations.
  3. Select history tab and observe the list item label.
  4. Add some expressions to memory (Control+M).
  5. Select memory and observe the label of memory entries.

Known issues with pull request:

None

Change log entries:

Bug fixes:

In Windows 10 Calculator, NVDA will announce labels for history and memory list items. (#11858)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

nvaccess#11858.

Regression in Calculator 10.2009 (Windows 10): history and memory list items have no labels (names) but its children provides necessary labels. Therefore treat children labels as the label for the history and memory list items. This issue is resolved in Calculator 10.2109 which is exclusive to Windows 11.
@josephsl josephsl requested a review from a team as a code owner January 3, 2022 18:49
@josephsl josephsl requested a review from seanbudd January 3, 2022 18:49
@josephsl

josephsl commented Jan 5, 2022

Copy link
Copy Markdown
Contributor Author

See microsoft/calculator#1628 as to how it was resolved from Microsoft side.

@seanbudd seanbudd merged commit d98edbd into nvaccess:master Jan 13, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 13, 2022
@josephsl josephsl deleted the i11858calculatorMemoryAndHistoryItems branch January 21, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvda is not reading the result of the accounts in the windows calculator history

3 participants