Windows 10 Calculator: give labels to history and memory list items#13213
Merged
seanbudd merged 4 commits intoJan 13, 2022
Merged
Conversation
nvaccess#11858. Regression in Calculator 10.2009 (Windows 10): history and memory list items have no labels (names) but its children provides necessary labels. Therefore treat children labels as the label for the history and memory list items. This issue is resolved in Calculator 10.2109 which is exclusive to Windows 11.
Contributor
Author
|
See microsoft/calculator#1628 as to how it was resolved from Microsoft side. |
seanbudd
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11858
Summary of the issue:
In Windows 10 Calculator (10.2009 and later), there is no label for history and memory list items.
Description of how this pull request fixes the issue:
Children of list items do provide necesary components ror memory and history itemss, therefor3e set list item labels based on what the children says.
Testing strategy:
Manual testing:
Known issues with pull request:
None
Change log entries:
Bug fixes:
In Windows 10 Calculator, NVDA will announce labels for history and memory list items. (#11858)
Code Review Checklist: