Skip to content

add automation name for history and memory list item#1628

Merged
oneonezhang merged 2 commits into
masterfrom
user/yiyzhan/accessibility
Aug 3, 2021
Merged

add automation name for history and memory list item#1628
oneonezhang merged 2 commits into
masterfrom
user/yiyzhan/accessibility

Conversation

@oneonezhang

Copy link
Copy Markdown
Contributor

Description of the changes:

  • Add automation name for history and memory list item
  • Set inner TextBlocks' AccessibilityView to Raw to avoid duplicate announcement when in scan mode

How changes were validated:

Passed build and manually tested.

@guominrui

Copy link
Copy Markdown
Member

Some UITest cases failed. Per the message snippet below, it should be because "HistoryItemValue" element's accessiblityView was set to Raw. We should update the UITest case accordingly to locate that element by Name or some other attributes.

https://dev.azure.com/ms/23383dcd-16bf-49fc-9556-1cb151958a4c/_apis/build/builds/205353/logs/42
{"using":"accessibility id","value":"HistoryItemValue"} 2021-07-30T09:39:29.7446164Z HTTP/1.1 404 Not Found 2021-07-30T09:39:29.7447363Z Content-Length: 139 2021-07-30T09:39:29.7448338Z Content-Type: application/json 2021-07-30T09:39:29.7449825Z {"status":7,"value":{"error":"no such element","message":"An element could not be located on the page using the given search parameters."}}

@guominrui guominrui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzhang54 hanzhang54 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oneonezhang oneonezhang merged commit d54403c into master Aug 3, 2021
@oneonezhang oneonezhang deleted the user/yiyzhan/accessibility branch August 3, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants