Conversation
This comment has been minimized.
This comment has been minimized.
michaelDCurran
approved these changes
Sep 20, 2021
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
With the suggested comment, I'm good with this.
Co-authored-by: Michael Curran <mick@nvaccess.org>
5 tasks
seanbudd
added a commit
that referenced
this pull request
Sep 20, 2021
Fixes the changelog message from #12862, for #12757 Summary of the issue: Turns out that #12862 was also a Windows 10 issue, and #12757 fixed the issue in both cases. Raised in this comment: #12757 (comment) Description of how this pull request fixes the issue: Changes the changelog message to be more general and consistent with other messages.
seanbudd
added a commit
that referenced
this pull request
Sep 21, 2021
…k in full (#12862) Fixes #12757 Summary of the issue: While navigating the calendar, NVDA reads days as follows: `26 data item August 2021 row 4 Th column 5` as opposed to `26 data item August 2021 row 4 Thursday column 5`. The abbreviated days of the week, which make up the column headers of the table and aren't focusable, are read. Instead, the UIA name of the column header should be read. Description of how this pull request fixes the issue: Adds: `UIATableItemPattern`, a small independent change that helped with investigating Abstracts shared code from `_get_rowHeaderText` and `_get_columnHeaderText` into `_getTextFromHeaderElement`. Overload `_getTextFromHeaderElement` in `CalendarViewDayItem` to read the correct label. Manually tested with Win11 using reproduction steps from #12757 Further work could be done to parse the date information and localize it, instead of reporting it as a table cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12757
Summary of the issue:
While navigating the calendar, NVDA reads days as follows:
26 data item August 2021 row 4 Th column 5as opposed to26 data item August 2021 row 4 Thursday column 5.The abbreviated days of the week, which make up the column headers of the table and aren't focusable, are read.
Instead, the UIA name of the column header should be read.
Description of how this pull request fixes the issue:
Adds:
UIATableItemPattern, a small independent change that helped with investigatingAbstracts shared code from
_get_rowHeaderTextand_get_columnHeaderTextinto_getTextFromHeaderElement.Overload
_getTextFromHeaderElementinCalendarViewDayItemto read the correct label.Testing strategy:
Manually tested with Win11 using reproduction steps from #12757
Known issues with pull request:
Further work could be done to parse the date information and localize it, instead of reporting it as a table cell.
Change log entries:
Bug fixes
Code Review Checklist: