Fix UnboundLocalError in _isUIAWindowHelper#12859
Merged
Merged
Conversation
Contributor
Author
|
Cc @LeonarddeR. |
michaelDCurran
approved these changes
Sep 18, 2021
Collaborator
|
Sorry for missing this. I think we really should clean up this code. It's really tricky and errorprone. Honestly, this is why I tend to avoid Python more and more. Having this kind of error pop up at runtime while it could easily be detected at compile time in other languages is just a shame! |
michaelDCurran
added a commit
that referenced
this pull request
Oct 26, 2021
This reverts commit 0ab3234.
5 tasks
michaelDCurran
added a commit
that referenced
this pull request
Oct 27, 2021
We have tried to switch to using UI automation to access MS Word documents by default in NVDA 2021.3. However, there are still several issues remaining with our UIA support. Switching to UIA by default should be held back until these are addressed. Some of these include: • Support for math: Support mathML UIA custom property in MS Word #12946 • Reporting of line numbers: Requires UIA custom patterns support\ Over the last couple of months our UIA support has had a lot of fixes and improvements, mainly spured on by the apparent need to switch due to NVDA and MS Word not playing well together with the introduction of Modern Comments in MS Word build 13901. However, a work around has been found for #12982 now, making the swich less of a high priority. Description of how this pull request fixes the issue: Reverts #12859 Reverts #12854 Reverts #12770
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #12854.
Summary of the issue:
In #12854 the
CanUseOlderInProcessApproachcheck was moved to run only when checking Office windows. However, it is also used to check whether to use UIA in Chromium.Description of how this pull request fixes the issue:
Move this check before all usages, restoring the ability to use UIA in Chromium.
Testing strategy:
Verified the functionality of UIA Word and Edgium.
Known issues with pull request:
None.
Change log entries:
None.
Code Review Checklist: