Remove usages of deprecated characterProcessing.SYMLVL_ constants and controlTypes helper functions#12836
Merged
Conversation
| import controlTypes | ||
| import versionInfo | ||
| from . import PlaceholderNVDAObject | ||
| from controlTypes.processAndLabelStates import _processNegativeStates, _processPositiveStates |
Member
There was a problem hiding this comment.
As much as this change is probably harmless, I don't see how it relates to the rest of the pr...
Member
Author
There was a problem hiding this comment.
This is a remaining deprecation that needed to be be performed. It was a bit verbose to add to the title and could be handled by a separate PR - it's justified in the PR description.
michaelDCurran
approved these changes
Sep 13, 2021
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Jul 29, 2024
Related to #12649, #12712, #12836 Summary of the issue: The mentioned prs performed a large refactor with constant changes Description of user facing changes None known Description of development approach Add the mentioned PRs to .git-blame-ignore-revs to ensure a properly configured git blame will ignore these changes, revealing the history of the underlying code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #12549
Summary of the issue:
characterProcessing.SYMLVL_* constants should be replaced using their equivalent SymbolLevel.* before 2022.1.
Unit testing for controlTypes helper functions needed updating for soon to be removed
processNegativeStatesandprocessPositiveStates.Description of how this pull request fixes the issue:
Update the usages of these constants and helper functions
Testing strategy:
Search the repo for
2022usages and noted deprecations in changes for developers.Ensure all code deprecated for removal in 2022.1 is not used in the codebase.
It seems like all deprecated code is removed from NVDA after this PR.
When we implement the removals we will still need to check that new usages haven't been introduced.
Known issues with pull request:
None
Change log entries:
N/A
Code Review Checklist: