Skip to content

Merge beta to master#12720

Merged
michaelDCurran merged 42 commits into
masterfrom
beta
Aug 8, 2021
Merged

Merge beta to master#12720
michaelDCurran merged 42 commits into
masterfrom
beta

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 7, 2021

Copy link
Copy Markdown
Member

Note: must be a merge commit, not a squash merge

josephsl and others added 30 commits July 29, 2021 18:58
Closes #12690

Summary of the issue:
Windows OCR feature is "limited" to Windows 10 when in fact it can be used in Windows 11 and later as well.

Description of how this pull request fixes the issue:
Rename Windows 10 OCR to Windows OCR.

* Content recognizers/UWP OCR: update copyright header, expand the scope to cover future Windows releases. Re #12690

* Settings: Windows 10 OCR -> Windows OCR. Re #12690

* Global commands: Windows 10 OCR -> Windows OCR. Re #12690

* User guide: Windows 10 OCR -> Windows OCR, anchors not changed. Re #12690

* update changes

Co-authored-by: buddsean <sean@nvaccess.org>
From translation svn revision: 63440

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
4591	4405	source/locale/de/LC_MESSAGES/nvda.po
51	0	user_docs/de/changes.t2t
17	4	user_docs/de/userGuide.t2t
 3 files changed, 4659 insertions(+), 4409 deletions(-)
From translation svn revision: 63440

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
4578	4371	source/locale/es/LC_MESSAGES/nvda.po
 1 file changed, 4578 insertions(+), 4371 deletions(-)
From translation svn revision: 63440

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
4559	4373	source/locale/fi/LC_MESSAGES/nvda.po
43	0	user_docs/fi/changes.t2t
15	3	user_docs/fi/userGuide.t2t
 3 files changed, 4617 insertions(+), 4376 deletions(-)
From translation svn revision: 63440

Authors:
Michel such <michel.such@free.fr>
Patrick ZAJDA <patrick@zajda.fr>
Remy Ruiz <remyruiz@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Cyrille Bougot <cyrille.bougot2@laposte.net>
Corentin Bacqué-Cazenave <corentin@progaccess.net>
Sylvie Duchateau <sylvieduchateau@gmail.com>
Sof <hellosof@gmail.com>

Stats:
4558	4387	source/locale/fr/LC_MESSAGES/nvda.po
51	0	user_docs/fr/changes.t2t
17	4	user_docs/fr/userGuide.t2t
 3 files changed, 4626 insertions(+), 4391 deletions(-)
From translation svn revision: 63440

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
4597	4390	source/locale/gl/LC_MESSAGES/nvda.po
 1 file changed, 4597 insertions(+), 4390 deletions(-)
From translation svn revision: 63440

Authors:
Hrvoje Katic <hrvojekatic@gmail.com>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Milo Ivir <mivir@milotype.de>
Dejana Rakic <dejana.rakic.2@gmail.com>

Stats:
4569	4377	source/locale/hr/LC_MESSAGES/nvda.po
43	0	user_docs/hr/changes.t2t
16	4	user_docs/hr/userGuide.t2t
 3 files changed, 4628 insertions(+), 4381 deletions(-)
From translation svn revision: 63440

Authors:
Takuya Nishimoto <nishimotz@gmail.com>
Minako Nonogaki <minakonono3519@gmail.com>

Stats:
1	1	user_docs/ja/changes.t2t
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 63440

Authors:
Grzegorz Zlotowicz <grzezlo@wp.pl>
Patryk Faliszewski <patric3031@wp.pl>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Dorota Krac <dorkakrac@yandex.com>
Piotr Rakowski <kontakt@piotrrakowski.net>
Hubert Meyer <hubmeyer1989@gmail.com>
Arkadiusz Swietnicki <nuno69a@gmail.com>

Stats:
4467	4282	source/locale/pl/LC_MESSAGES/nvda.po
 1 file changed, 4467 insertions(+), 4282 deletions(-)
From translation svn revision: 63440

Authors:
Cleverson Casarin Uliana <clul@mm.st>
Marlin Rodrigues <marlincgrodrigues@yahoo.com.br>
Tiago Melo Casal <tcasal@intervox.nce.ufrj.br>

Stats:
4562	4378	source/locale/pt_BR/LC_MESSAGES/nvda.po
51	0	user_docs/pt_BR/changes.t2t
18	5	user_docs/pt_BR/userGuide.t2t
 3 files changed, 4631 insertions(+), 4383 deletions(-)
From translation svn revision: 63440

Authors:
Nikola Jovic <wwenikola123@gmail.com>
Janko Valencik <janko.valencik@alfanum.co.rs>
Zvonimir <9a5dsz@gozaltech.org>
Danijela Popovic <vlajna95@gmail.com>

Stats:
4561	4376	source/locale/sr/LC_MESSAGES/nvda.po
39	0	user_docs/sr/changes.t2t
 2 files changed, 4600 insertions(+), 4376 deletions(-)
From translation svn revision: 63440

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
4549	4364	source/locale/tr/LC_MESSAGES/nvda.po
16	3	user_docs/tr/userGuide.t2t
 2 files changed, 4565 insertions(+), 4367 deletions(-)
From translation svn revision: 63440

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
4461	4279	source/locale/vi/LC_MESSAGES/nvda.po
43	0	user_docs/vi/changes.t2t
16	3	user_docs/vi/userGuide.t2t
 3 files changed, 4520 insertions(+), 4282 deletions(-)
From translation svn revision: 63440
From translation svn revision: 63634

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
35	39	source/locale/de/LC_MESSAGES/nvda.po
 1 file changed, 35 insertions(+), 39 deletions(-)
From translation svn revision: 63634

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
55	95	source/locale/es/LC_MESSAGES/nvda.po
62	0	user_docs/es/changes.t2t
28	18	user_docs/es/userGuide.t2t
 3 files changed, 145 insertions(+), 113 deletions(-)
From translation svn revision: 63634

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
34	40	source/locale/fi/LC_MESSAGES/nvda.po
17	6	user_docs/fi/changes.t2t
21	23	user_docs/fi/userGuide.t2t
 3 files changed, 72 insertions(+), 69 deletions(-)
From translation svn revision: 63634

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
56	96	source/locale/gl/LC_MESSAGES/nvda.po
62	0	user_docs/gl/changes.t2t
29	19	user_docs/gl/userGuide.t2t
 3 files changed, 147 insertions(+), 115 deletions(-)
From translation svn revision: 63634

Authors:
Hrvoje Katic <hrvojekatic@gmail.com>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Milo Ivir <mivir@milotype.de>
Dejana Rakic <dejana.rakic.2@gmail.com>

Stats:
37	43	source/locale/hr/LC_MESSAGES/nvda.po
16	6	user_docs/hr/changes.t2t
 2 files changed, 53 insertions(+), 49 deletions(-)
From translation svn revision: 63634

Authors:
Takuya Nishimoto <nishimotz@gmail.com>
Minako Nonogaki <minakonono3519@gmail.com>

Stats:
4443	4296	source/locale/ja/LC_MESSAGES/nvda.po
27	17	user_docs/ja/userGuide.t2t
 2 files changed, 4470 insertions(+), 4313 deletions(-)
From translation svn revision: 63634

Authors:
Joseph Lee <joseph.lee22590@gmail.com>
Chang-Hwan Jang <462356@gmail.com>
Dong Hee Park <hi@aheu.org>
Stanley Chung <stanley@mail.com>

Stats:
4464	4297	source/locale/ko/LC_MESSAGES/nvda.po
 1 file changed, 4464 insertions(+), 4297 deletions(-)
From translation svn revision: 63634

Authors:
Grzegorz Zlotowicz <grzezlo@wp.pl>
Patryk Faliszewski <patric3031@wp.pl>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Dorota Krac <dorkakrac@yandex.com>
Piotr Rakowski <kontakt@piotrrakowski.net>
Hubert Meyer <hubmeyer1989@gmail.com>
Arkadiusz Swietnicki <nuno69a@gmail.com>

Stats:
39	45	source/locale/pl/LC_MESSAGES/nvda.po
27	27	user_docs/pl/userGuide.t2t
 2 files changed, 66 insertions(+), 72 deletions(-)
From translation svn revision: 63634

Authors:
Diogo Costa <diogojoca@gmail.com>
Rui Batista <ruiandrebatista@gmail.com>
Rui Fontes <rui.fontes@tiflotecnia.com>
Ângelo Abrantes <ampa4374@gmail.com>

Stats:
4594	4411	source/locale/pt_PT/LC_MESSAGES/nvda.po
 1 file changed, 4594 insertions(+), 4411 deletions(-)
From translation svn revision: 63634

Authors:
Dan Pungă <dan.punga@gmail.com>
Florian Ionașcu <7ro2014@gmail.com>
Alexandru Matei <alexandrumateistelian@gmail.com>
Nicuşor Untilă <nicusoruntila@yahoo.com>
Adriani Ionuț Botez <ionutz_tero@yahoo.com>
Dragoș Grecianu <grecianu.dragos@gmail.com>
Daniela Popovici <vlajna95@gmail.com>
George Antonio Andrei <george.andrei2002@gmail.com>

Stats:
4572	4405	source/locale/ro/LC_MESSAGES/nvda.po
61	0	user_docs/ro/changes.t2t
 2 files changed, 4633 insertions(+), 4405 deletions(-)
From translation svn revision: 63634

Authors:
Nikola Jovic <wwenikola123@gmail.com>
Janko Valencik <janko.valencik@alfanum.co.rs>
Zvonimir <9a5dsz@gozaltech.org>
Danijela Popovic <vlajna95@gmail.com>

Stats:
35	43	source/locale/sr/LC_MESSAGES/nvda.po
 1 file changed, 35 insertions(+), 43 deletions(-)
From translation svn revision: 63634

Authors:
Dinakar T.D. <td.dinkar@gmail.com>

Stats:
4568	4402	source/locale/ta/LC_MESSAGES/nvda.po
 1 file changed, 4568 insertions(+), 4402 deletions(-)
From translation svn revision: 63634

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
33	38	source/locale/tr/LC_MESSAGES/nvda.po
4	2	source/locale/tr/gestures.ini
18	21	user_docs/tr/userGuide.t2t
 3 files changed, 55 insertions(+), 61 deletions(-)
From translation svn revision: 63634

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
32	38	source/locale/vi/LC_MESSAGES/nvda.po
21	10	user_docs/vi/changes.t2t
20	23	user_docs/vi/userGuide.t2t
 3 files changed, 73 insertions(+), 71 deletions(-)
From translation svn revision: 63634
From translation svn revision: 63697

Authors:
Daniel K. Gartmann <kontakt@nvda.dk>
Nicolai Svendsen <chojiro1990@gmail.com>
bue@vester-andersen.dk

Stats:
4483	4316	source/locale/da/LC_MESSAGES/nvda.po
37	21	user_docs/da/userGuide.t2t
 2 files changed, 4520 insertions(+), 4337 deletions(-)
NVDA translation automation and others added 12 commits August 6, 2021 00:00
From translation svn revision: 63697

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
17	6	user_docs/de/changes.t2t
22	24	user_docs/de/userGuide.t2t
 2 files changed, 39 insertions(+), 30 deletions(-)
From translation svn revision: 63697

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
20	20	user_docs/es/userGuide.t2t
 1 file changed, 20 insertions(+), 20 deletions(-)
From translation svn revision: 63697

Authors:
Michel such <michel.such@free.fr>
Patrick ZAJDA <patrick@zajda.fr>
Remy Ruiz <remyruiz@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Cyrille Bougot <cyrille.bougot2@laposte.net>
Corentin Bacqué-Cazenave <corentin@progaccess.net>
Sylvie Duchateau <sylvieduchateau@gmail.com>
Sof <hellosof@gmail.com>

Stats:
37	43	source/locale/fr/LC_MESSAGES/nvda.po
17	6	user_docs/fr/changes.t2t
18	21	user_docs/fr/userGuide.t2t
 3 files changed, 72 insertions(+), 70 deletions(-)
From translation svn revision: 63697

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
20	20	user_docs/gl/userGuide.t2t
 1 file changed, 20 insertions(+), 20 deletions(-)
From translation svn revision: 63697

Authors:
Shmuel Naaman <shmuel_naaman@yahoo.com>

Stats:
8	8	source/locale/he/symbols.dic
 1 file changed, 8 insertions(+), 8 deletions(-)
From translation svn revision: 63697

Authors:
zvonimir stanecic <9a5dsz@gozaltech.org>
Ertay Shashko <ertay@outlook.com>
Aleksandar <glupav@gmail.com>
Kiko Lazarev <kristijan.lazarev@gmail.com>

Stats:
4502	4337	source/locale/mk/LC_MESSAGES/nvda.po
 1 file changed, 4502 insertions(+), 4337 deletions(-)
From translation svn revision: 63697

Authors:
Bram Duvigneau <bram@bramd.nl>
Bart Simons <bart@bartsimons.be>
A Campen <a.campen@wxs.nl>
Leonard de Ruijter <alderuijter@gmail.com>

Stats:
27	17	user_docs/nl/userGuide.t2t
 1 file changed, 27 insertions(+), 17 deletions(-)
From translation svn revision: 63697

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
2	2	source/locale/tr/LC_MESSAGES/nvda.po
79	79	user_docs/tr/userGuide.t2t
 2 files changed, 81 insertions(+), 81 deletions(-)
From translation svn revision: 63697

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
1	1	user_docs/vi/changes.t2t
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 63697
Adds a release blurb and proposes some changes to the changelog and userGuide.
Link to issue number:
Fixes #12624

Summary of the issue:
When opening a submenu in certain applications (like Thunderbird 78.12),
NVDA can process a menu start event after the first item in the menu is focused.
The menu start event causes a focus event on the menu, taking NVDA's focus from the menu item.
Additionally, the "menu" parent of the submenu item is not keyboard focusable, and is separate from
the menu item which triggered the submenu.
The object tree in this case (menu item > submenu (not keyboard focusable) > submenu item).
The focus event order after activating the menu item's sub menu is (submenu item, submenu).

Description of how this pull request fixes the issue:
Before cancelling speech, check that the focus is now on the parent menu.

Testing strategy:
Manual testing (note that this does not always occur and is hard to consistently reproduce):

Enable debug logging
With a Thunderbird 78.12 context menu (activate one on an email, for example)
navigate to a menu item with a submenu.
Activate it.
Examine the logs for an event (submenu item, submenu) - eg the speech is announced in this order in the logs, as are the events if event debugging is enabled.
On this PR: Confirm that this case has extensive logging when it occurs. When this event occurs confirm that the menu item is spoken, followed by the submenu. If you want to hear a beep on this event, change the logging to an error beep.
On 2021.1: Confirm that only menu item is spoken, as the seubmenu item is cancelled.
Known issues with pull request:
This may be an overzealous check. Speech in similar contexts that should be cancelled may continue to be spoken.
As such, debug logs are added to make handling new cases easier until the root problem of event processing is addressed.
@michaelDCurran michaelDCurran merged commit 3c29f9a into master Aug 8, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Windows 10 OCR to Windows OCR First item not read when opening context submenu

5 participants