Skip to content

Add a release blurb and fixup changes for 2021.2#12700

Merged
seanbudd merged 7 commits into
betafrom
userDocsChanges2021.2
Aug 7, 2021
Merged

Add a release blurb and fixup changes for 2021.2#12700
seanbudd merged 7 commits into
betafrom
userDocsChanges2021.2

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 30, 2021

Copy link
Copy Markdown
Member

Description

Adds a release blurb and proposes some changes to the changelog and userGuide.

Testing strategy

I performed a review of git diff release-2021.1 userDocsChanges2021.2 user_docs/en/*.t2t.

The build artifact for changes.html and userGuide.html should be checked before merging.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd added this to the 2021.2 milestone Jul 30, 2021
@seanbudd seanbudd requested a review from Qchristensen July 30, 2021 01:02
@seanbudd seanbudd requested review from a team as code owners July 30, 2021 01:02
@seanbudd seanbudd requested review from feerrenrut and michaelDCurran and removed request for a team July 30, 2021 01:02
Comment thread user_docs/en/changes.t2t Outdated

== Important notes ==
- Screen Curtain on previous releases of NVDA is no longer compatible with versions of Windows newer than Windows 10 21H2 (10.0.19044).
Screen Curtain is no longer compatible when using versions of NVDA older than 2021.2 with Windows newer than Windows 10 21H2 (10.0.19044).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer than

Shouldn't this be "when using x or later"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yes, that is the case as far as I'm aware. Before I fix this (across the rest of the documentation) I'm going to check this via the release preview channel for WIN1021H2. I have confirmed the previous release of Windows works, Windows 10 21H1.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of behaviour occurred in an insiders build, #12491 reports this change of behaviour for a build sometime after the WIN10 21H2 build number. I am yet to be able to test WIN10 21H2 preview (haven't been offered the update). It would be good if someone can confirm whether or not screen curtain works with the WIN10 21H2 preview, but for now I will move forward to say "when using it or later" due to being uncertain.

Comment thread user_docs/en/changes.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
Comment thread user_docs/en/changes.t2t Outdated
@seanbudd seanbudd requested a review from feerrenrut August 3, 2021 07:25
michaelDCurran
michaelDCurran previously approved these changes Aug 5, 2021

@michaelDCurran michaelDCurran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Comment thread user_docs/en/changes.t2t Outdated
feerrenrut
feerrenrut previously approved these changes Aug 5, 2021

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is fine.

Just a couple of ideas, trying to make the language for the screen curtain edge cases as simple as possible.

Comment thread user_docs/en/changes.t2t Outdated
@seanbudd seanbudd dismissed stale reviews from feerrenrut and michaelDCurran via 00fa3ee August 6, 2021 00:11
@seanbudd

seanbudd commented Aug 6, 2021

Copy link
Copy Markdown
Member Author

@feerrenrut - I've rephrased this message across both files now. Let me know what you think.

@seanbudd seanbudd requested a review from feerrenrut August 6, 2021 00:13
@seanbudd seanbudd merged commit 7028d2e into beta Aug 7, 2021
@seanbudd seanbudd deleted the userDocsChanges2021.2 branch August 7, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants