Merge beta to master#12698
Merged
Merged
Conversation
Fixes #12653 # Summary: PR #11856 introduced speaking symbols when navigating by word. The changes produced an unintended side effect of double processing symbols. The text replacement for symbols gets spoken at symbol level all. # Description of fix: There isn't enough time before release to be confident in a fix for this behavior, instead the feature is reverted. Reverting is in commit 619e5f7 Some changes have been kept: - Symbol level enum: used in other aspects of the code and isn't a cause of this issue - System test for notepad: Useful to confirm behavior for reading by word is not changed when this feature is re-introduced. # Testing strategy: Notepad system test Generated and checked output of changes doc and userGuide Ran NVDA with symbolLevelWordAll = True remaining in config (a problem here would only affect alpha users anyway).
Link to issue number: Fix for #12491 Summary of the issue: Screen curtain does not work as intended for new Windows builds. This is due to an API change. Previously, NVDA used a fully transparent colour transformation to create the screen curtain, which now no longer results in a black screen. In the future, the API is unstable: "The Magnification API is not supported under WOW64; that is, a 32-bit magnifier application will not run correctly on 64-bit Windows.". Description of how this pull request fixes the issue: Implements the screen curtain with a fully solid opacity. Adds a warning to test newer Windows builds when using screen curtain. Testing strategy: Test starting screencurtain using this PR build on a Windows 10 insiders build Test starting screencurtain using this PR build on a Windows 11 insiders build Test starting screencurtain using this PR build on a Windows 10 stable build Test starting screencurtain using this PR build on a Windows 8 stable build Known issues with pull request: This may occur again in the future due to the API not being fully supported, or another undefined behaviour change like this one. It would be good to add a test that confirms the screen is black using an independent tool, and/or move towards a different API.
This was
linked to
issues
Jul 29, 2021
michaelDCurran
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be a merge commit not a squash merge