Skip to content

Partial revert of PR #11856#12695

Merged
feerrenrut merged 7 commits into
betafrom
fix-12653
Jul 29, 2021
Merged

Partial revert of PR #11856#12695
feerrenrut merged 7 commits into
betafrom
fix-12653

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #12653

Summary of the issue:

PR #11856 introduced speaking symbols when navigating by word.
The changes produced an unintended side effect of double processing symbols.
The text replacement for symbols gets spoken at symbol level all.

Description of how this pull request fixes the issue:

There isn't enough time to be confident in a fix for this behavior, instead the feature is reverted.
Reverting is in commit 619e5f7
Some changes have been kept:

  • Symbol level enum: used in other aspects of the code and isn't a cause of this issue
  • System test for notepad: Useful to confirm behavior for reading by word is not changed when this feature is re-introduced.

Testing strategy:

  • Notepad system test
  • Generated and checked output of changes doc and userGuide
  • Ran NVDA with symbolLevelWordAll = True remaining in config (a problem here would only affect alpha users anyway).

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@feerrenrut feerrenrut marked this pull request as ready for review July 28, 2021 10:08
@feerrenrut feerrenrut requested review from a team as code owners July 28, 2021 10:08
@feerrenrut feerrenrut requested review from Qchristensen and seanbudd and removed request for a team July 28, 2021 10:08
@seanbudd seanbudd linked an issue Jul 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Punctuation read in symbol description when moving by character

3 participants