Partial revert of PR #11856#12695
Merged
Merged
Conversation
Disables "symbolLevelWord" test Adjusts expectations
seanbudd
approved these changes
Jul 29, 2021
This was referenced Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12653
Summary of the issue:
PR #11856 introduced speaking symbols when navigating by word.
The changes produced an unintended side effect of double processing symbols.
The text replacement for symbols gets spoken at symbol level all.
Description of how this pull request fixes the issue:
There isn't enough time to be confident in a fix for this behavior, instead the feature is reverted.
Reverting is in commit 619e5f7
Some changes have been kept:
Testing strategy:
symbolLevelWordAll = Trueremaining in config (a problem here would only affect alpha users anyway).Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: