Downgrade espeak to aafd2e720#12495
Merged
Merged
Conversation
Contributor
|
For reference, information about Chinese dictionary compilation: espeak-ng/espeak-ng#933 |
8 tasks
Collaborator
|
How about the references to speech player? |
|
I was not aware this still worked.
|
Member
Author
Which references? If you mean within the |
Collaborator
|
Ah, thanks for clarifying. I wasn't aware speech player was merged in espeak upstream. |
feerrenrut
approved these changes
Jun 2, 2021
Contributor
|
This is weird, the appveyor build has completed and succeeded, but GitHub still shows it as pending. I'm going to go ahead and merge this. |
seanbudd
added a commit
that referenced
this pull request
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #12465
Summary of the issue:
The latest espeak, used in beta, has a blocking issue. As such, we are reverting to the last known stable espeak.
Description of how this pull request fixes the issue:
Reverts to espeak in release 2020.4 which is
aafd2e720.The strategy to updating was to follow the updating espeak readme.
Choosing the commit:
And then applying the results of
git diff f6d092a9c13d864ede78c493f64a7d32cde41f09 aafd2e720582d7ccdadef675ce656903bc775c1d Makefile.amwithin the espeak project.Testing strategy:
NVDA builds, ensure espeak continues to work as expected like 2020.4.
Known issues with pull request:
None
Change log entries:
Changes: remove mention of update to espeak.
Note: 2020.4 didn't mention the upgrade to espeak. As such, those using the changelog to figure out the latest espeak version may be misled.
Code Review Checklist: