Windows 10 Calculator: let braille output expressions, even when Delete key is pressed to clear calculator expressions#12486
Merged
seanbudd merged 7 commits intoMay 31, 2021
Conversation
…access#12268. Braille output is missing when entering calculations, caused by the fact that NVDA will ignore 'displayUpdated' activity Id in consideration for speak typed characters being enabled. Therefore announce expressions in braille always.
…mands that should be announced. Re nvaccess#12268. Add Delete and Numpad Delete (clear expression) commands to list of commands that should be reported.
…ccess#12268. When results commands are performed (Escape, Enter, Delete), announce results in both speech and braille instead of speech alone.
…CalculatorOutputAndDeleteCommands
seanbudd
approved these changes
May 31, 2021
Contributor
Author
|
Hi, oops, a really bad typo – thanks for fixing it.
From: Sean Budd ***@***.***>
Sent: Monday, May 31, 2021 12:30 AM
To: nvaccess/nvda ***@***.***>
Cc: Joseph Lee ***@***.***>; Author ***@***.***>
Subject: Re: [nvaccess/nvda] Windows 10 Calculator: let braille output expressions, even when Delete key is pressed to clear calculator expressions (#12486)
@seanbudd approved this pull request.
Strategy looks good to me, I've fixed a typo though.
_____
In source/appModules/calculator.py <#12486 (comment)> :
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
-# Copyright (C) 2020 NV Access Limited, Joseph Lee
+# Copyright (C) 202002921 NV Access Limited, Joseph Lee
⬇️ Suggested change
-# Copyright (C) 202002921 NV Access Limited, Joseph Lee
+# Copyright (C) 2020-2021 NV Access Limited, Joseph Lee
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#12486 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEBHEPVL4UWLNJI7HGTTQM3I3ANCNFSM452JMLVA> .
|
1afbb91 to
4b5a958
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Tested via Windows 10 App Essentials add-on for a while:
Link to issue number:
Closes #12268
Summary of the issue:
When entering expressions, no braille feedback is given, including when Delete key is pressed to clear expressions.
Description of how this pull request fixes the issue:
Adds Delete (including Numpad Delete) as a Calculator command, along with changing from reportfocus to ui.message in results script so braille output can function.
Testing strategy:
Manual testing required (cannot be tested via AppVeyor as the VM runs Windows Server 2016/2019 which does not come with modern Windows 10 Calculator):
Known issues with pull request:
None
Change log entries:
Bug fixes:
In Windows 10 Calculator, NVDA will announce calculator expressions on a braille display. (#12268)
Code Review Checklist:
Thanks.