Use Diff Match Patch by default when available#12485
Merged
Merged
Conversation
seanbudd
approved these changes
May 31, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I have a suggestion for a docs change but the code looks good to me. Also pending approval from @Qchristensen
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Member
|
userGuide change looks good - is there a change log entry? It's hiding from me. |
Member
|
@Qchristensen - we generally update the changelog manually just before merging. I've added this now, just need your approval to merge. |
Qchristensen
approved these changes
Jun 2, 2021
Qchristensen
left a comment
Member
There was a problem hiding this comment.
UserGuide & Changes text looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#3200.
Summary of the issue:
Diff Match Patch (DMP) was included but disabled by default in 2021.1. It fixes #3200 and allows for drastically fewer cross-process calls in UIA console, improving performance in busy applications.
Description of how this pull request fixes the issue:
This PR enables DMP by default to allow for wider user testing in master snapshots. If user feedback is positive, use by default in 2021.2.
Testing strategy:
Verified that DMP is used by default when feature flag is set to auto and Difflib when feature flag is set to force Difflib.
Known issues with pull request:
None.
Change log entries:
== Bug Fixes ==
Code Review Checklist: