Skip to content

Revert "refactor the exit of nvda and gui.terminate"#12326

Merged
michaelDCurran merged 1 commit into
masterfrom
revert-12286-cleanup-exit
Apr 23, 2021
Merged

Revert "refactor the exit of nvda and gui.terminate"#12326
michaelDCurran merged 1 commit into
masterfrom
revert-12286-cleanup-exit

Conversation

@seanbudd

@seanbudd seanbudd commented Apr 22, 2021

Copy link
Copy Markdown
Member

Reverts #12286

@seanbudd seanbudd requested a review from a team as a code owner April 22, 2021 23:52
@seanbudd seanbudd requested a review from michaelDCurran April 22, 2021 23:52
@AppVeyorBot

AppVeyorBot commented Apr 23, 2021

Copy link
Copy Markdown

See test results for failed build of commit 57dc902eba

@michaelDCurran michaelDCurran merged commit d9afe35 into master Apr 23, 2021
@michaelDCurran michaelDCurran deleted the revert-12286-cleanup-exit branch April 23, 2021 03:55
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 23, 2021
@Brian1Gaff

Brian1Gaff commented Apr 23, 2021 via email

Copy link
Copy Markdown

@seanbudd

seanbudd commented Apr 23, 2021

Copy link
Copy Markdown
Member Author

You are aware that the current alpha as of yesterday is seriously broken, and will not run sensibly on anything I suppose? Brian @.*** Sent via blueyonder. Please address personal E-mail to:- @., putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Michael Curran" @.> To: "nvaccess/nvda" @.> Cc: "Subscribed" @.> Sent: Friday, April 23, 2021 4:56 AM Subject: Re: [nvaccess/nvda] Revert "refactor the exit of nvda and gui.terminate" (#12326)
…
Merged #12326 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #12326 (comment)

Just to confirm, you are referring to the latest alpha alpha-22498,d9afe35d, which includes this PR that has reverted the broken change?

@CyrilleB79

CyrilleB79 commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

@seanbudd, @michaelDCurran:
Since #12286 was reverted through this PR, shouldn't #12238 be reopened?

@seanbudd seanbudd mentioned this pull request Apr 26, 2021
Closed
@seanbudd

seanbudd commented Apr 26, 2021

Copy link
Copy Markdown
Member Author

Yes, thanks @CyrilleB79

@seanbudd seanbudd self-assigned this Apr 28, 2021
@seanbudd seanbudd mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

Assignees

@seanbudd seanbudd

Labels

None yet

Projects

None yet

Milestone

2021.1

Development

Successfully merging this pull request may close these issues.

6 participants

@seanbudd @AppVeyorBot @Brian1Gaff @CyrilleB79 @michaelDCurran @nvaccessAuto