Move report formatting changes box to the correct parent#12307
Merged
Move report formatting changes box to the correct parent#12307
Conversation
7 tasks
michaelDCurran
approved these changes
Apr 20, 2021
Member
michaelDCurran
left a comment
There was a problem hiding this comment.
As an NVDA user I can also verify this fix, as before this pr NVDA would incorrectly announce the Elements grouping when shift tabbing from the Ok button to the Report Formatting changes after the cursor checkbox. This checkbox should not be in the Elements grouping. With this pr entering the Elements grouping is only announced when shift tabbing from okay, and again past this checkbox to the Clickable checkbox, which is again correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In #12181, the setting "Report formatting changes after the cursor" in "Document Formatting" was incorrectly moved to the wrong parent, the static box grouping above it, making it invisible to the user. It is currently readable using NVDA but not graphically visible to the user
This was noticed when testing #12300
Description of how this pull request fixes the issue:
Revert the change in #12181, making the parent the Settings Panel itself
Testing strategy:
Ensure the new control is visible
This can be done using the tools made in #12308
Known issues with pull request:
None
Change log entry:
None, regression
Code Review Checklist: