Create tool for comparing GUI and UI elements in copies of NVDA#12308
Create tool for comparing GUI and UI elements in copies of NVDA#12308
Conversation
eca1271 to
1b22093
Compare
feerrenrut
left a comment
There was a problem hiding this comment.
Let's go ahead with this. I wonder if this would be simpler not to have a particular version's output checked in, rather just require that a developer run this tool against multiple versions independently and manually diff the output.
I'm also a little worried that this will stop working if it is not being run regularly (eg via automated tests).
I don't think we need to do anything about these concerns now, lets just pay attention to how this goes.
I thought about this, at least now both workflows work. I would think if we were to do this automated, some version would have to be checked in though to save build times. My thoughts of adding automated tests is to rename the folder "master", check in what master reads instead and then run the system test against that. That way we can track the changes to dialogs with PRs. If we want to run this less regularly, we can just run the system test when the target of the PR is beta/release. |
Link to issue number:
None
Summary of the issue:
GUI and UI features for NVDA can become lost through code refactors such as #12181. Generating screenshots and comparing text across copies of NVDA is an annoying process for developers.
Description of how this pull request fixes the issue:
A tool is created using our system tests to generate screenshots and text of all the content in NVDA settings. This can be expanded upon to include other GUI and UI features of NVDA.
See the README for usage.
Testing strategy:
None, adds a testing tool
Known issues with pull request:
Can be expanded to include more GUI/UI features.
Change log entry:
None, developer tool
Code Review Checklist: