Remove Adobe Flash support from NVDA#12207
Conversation
|
Ideally we update miscdeps after merging nvaccess/nvda-misc-deps#21 |
If it has no real downside for the NVDA maintainability, it'd suggest keeping the Flash support until 2022.1 to ensure to not disturb business users. There are maybe users still needing Flash and the Flash end of support is quite recent. |
|
It seems though that although flash sites are out there in the small
independent space, many of them were never very accessible since the writers
chose to make them that way. If it does no harm leaving it though, why not
save any hassle that this might cause and leave it in?
Brian
|
|
I support removing adobe flash support from NVDA |
|
Its still on my machine from what I can see, it apparently was last used
three days ago, but I don't remember it, I think it may have been an audio
player embedded on a page though.
Brian
|
|
Just for reference, the major browsers have all dropped support for flash:
Someone wishing to continue using Flash will need to be using an out of date browser. |
feerrenrut
left a comment
There was a problem hiding this comment.
The changes look fine to me. Though I'd ask that you please update the description to include your process for finding and removing Flash support. We can then review that process rather than just the changed files.
I'd also like @michaelDCurran to take a look at this.
|
This is good. The code for flash is just ded code rite now. I am happy to see the back of flash. |
|
@feerrenrut I updated the description. The procedure was quite simple, Flash code was dug up by using |
It still exists Firefox ESR version which will be supported until 2021-09-07. See there for details: https://wiki.mozilla.org/Release_Management/Calendar |
|
While normally keeping support for Flash would have no disadvantage IMHO in this case it is broken already ((see #11131) and therefore people needing to use it are required to use older version of NVDA already. Since trying to fix it at this stage of Flash's lifetime is no good use of anyone's time I agree with the removal. |
|
This PR also closes issue #12162. |
Link to issue number:
Closes #11131
Summary of the issue:
Adobe Flash is no longer supported and even actively removed from every PC and browser.
Description of how this pull request fixes the issue:
Remove Flash support from NVDA.
Flash code was dug up by using
git grep -i flashin the NVDA repo.Testing strategy:
This only has to do with removing code. It is hard to test something that has been removed, especially now Flash is also no longer available to test this with. There were also several reports of things being broken already beforehand.
Known issues with pull request:
People who still need Flash will have to use an older version of NVDA. I think this is fine, as the use of Flash is strongly discouraged en is actively opposed. People really need to know what they do.
Change log entry:
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.