Python 3.8: Mention additional system requirements for Windows 7#12141
Merged
michaelDCurran merged 2 commits intonvaccess:py3.8from Mar 11, 2021
Merged
Conversation
Contributor
|
Apart from spelling and grammar, it looks fantastic - thanks for pointing these out. |
michaelDCurran
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, related to #12064
Summary of the issue:
Python 3.8 introduced changes to the way in which dll's are loaded on Windows. This however does not work on clean installs of Windows 7 - a specific update needs to be installed.
Description of how this pull request fixes the issue:
User guide has been updated to mention that on Windows 7 SP1 KB3063858 has to be installed. I've mentioned KB3063858 specifically rather than KB2533623 which is mentioned in the Python issue above as KB3063858 replaces it and KB2533623 can no longer be downloaded from Microsoft servers anyway.
Testing strategy:
Manual testing:
Changes like these cannot be unit tested and we don't have system tests running under Windows 7.
I've also compiled user guide and ensured that it displays correctly.
Known issues with pull request:
I haven't tested specifically on Server 2008 R2 but since it is based on the same sources as Windows 7 I don't expect any troubles here.
Change log entry:
None needed - Python 3.8 is not in a release yet.
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.