Skip to content

Python 3.8: Mention additional system requirements for Windows 7#12141

Merged
michaelDCurran merged 2 commits intonvaccess:py3.8from
lukaszgo1:py3.8Win7AdditionalRequirements
Mar 11, 2021
Merged

Python 3.8: Mention additional system requirements for Windows 7#12141
michaelDCurran merged 2 commits intonvaccess:py3.8from
lukaszgo1:py3.8Win7AdditionalRequirements

Conversation

@lukaszgo1
Copy link
Copy Markdown
Contributor

Link to issue number:

None, related to #12064

Summary of the issue:

Python 3.8 introduced changes to the way in which dll's are loaded on Windows. This however does not work on clean installs of Windows 7 - a specific update needs to be installed.

Description of how this pull request fixes the issue:

User guide has been updated to mention that on Windows 7 SP1 KB3063858 has to be installed. I've mentioned KB3063858 specifically rather than KB2533623 which is mentioned in the Python issue above as KB3063858 replaces it and KB2533623 can no longer be downloaded from Microsoft servers anyway.

Testing strategy:

Manual testing:

Changes like these cannot be unit tested and we don't have system tests running under Windows 7.

I've also compiled user guide and ensured that it displays correctly.

Known issues with pull request:

I haven't tested specifically on Server 2008 R2 but since it is based on the same sources as Windows 7 I don't expect any troubles here.

Change log entry:

None needed - Python 3.8 is not in a release yet.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@josephsl
Copy link
Copy Markdown
Contributor

Apart from spelling and grammar, it looks fantastic - thanks for pointing these out.

@michaelDCurran michaelDCurran merged commit cc7d219 into nvaccess:py3.8 Mar 11, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Mar 11, 2021
@lukaszgo1 lukaszgo1 deleted the py3.8Win7AdditionalRequirements branch March 11, 2021 10:52
michaelDCurran added a commit that referenced this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants