Link to issue number:

Fixes #9295

Summary of the issue:

In Skype for Business (at least Office 2016, version 16.0.5095.1000), the incoming messages are not reported and an error occurs in the log instead.
This error show that the message has a value set to None whereas the code expects a string in order to parse it.
(cf. #9295 (comment) for more details)

Description of how this pull request fixes the issue:

• If the message value is None, parse only the message name to split the content from author and timestamp parts. For this, we just look at ", , " separators.
• If the message is not None, use as previously the message name and the message value to split author, content and timestamp of the message.

I suppose that the message value may be None or not according to Skype / Lync version. I do not had the opportunity to check however on other Skype / Lync version.

I did not remove the old way to do because of the following comment:

# Example string: "Michael Curran : , , Hello\r\n\r\nThis is a test , 10:45 am."
In this comment, we can see that there is no ', , ' separator between content and timestamp. Did it change between various versions of Skype / Lync? Or is the example in the comment just not correct? Since I do not know, I have kept the two paths.

Testing strategy:

• Tested on Skype for Business, Office 2016, version 16.0.5095.1000).
• Would need to be tested on other versions: Lync (Office 2013), Office 365
  However, since I have not found someone to test on other versions of Skype for Business, the old path (when message value is not None) will be tested on alpha. I have taken care however to keep as much as possible the old path code in order to limit risks of regression.
• It does not seem to me that unit tests are required for such modifications.
• I do not think that we have an environment to perform system tests on Skype for Business or more generally Office.

Known issues with pull request:

Missing tests on other versions of Office due to lakc of testers; will be tested on alpha.

Change log entry:

Section: Bug fixes
The incoming messages in the chat of Skype for Business are reported again. (#9295)

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual tests.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.