Fix up of 11738: Force UIA for BrokenCommctrl5Item controls, even though they don't support UIA natively#11828
Merged
Merged
Conversation
…pport UIA natively
Contributor
Author
michaelDCurran
requested changes
Nov 10, 2020
Contributor
Author
|
@michaelDCurran Done. |
michaelDCurran
approved these changes
Nov 12, 2020
7 tasks
michaelDCurran
pushed a commit
that referenced
this pull request
Apr 20, 2021
…oesn't support UIA natively (#12241) PR #11738 made it impossible to use UIA for controls which doesn't report as native UIA. This decreased accessibility of Outlook's messages list in some versions of Outlook (certainly for 2010 and possibly for 2013) which reports as non native UIA. Description of how this pull request fixes the issue: Similar to the fix in #11828 for these controls the fact that they're non native UIA is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11797
Summary of the issue:
In #11738 before using UIA for a particular control we added a check to ensure that the control in question supports UIA natively. This unfortunately broke access to tree view items used in Windows HTML help since for these controls we're using UIA explicitly even though they're not native (MSAA is broken for them).
Description of how this pull request fixes the issue:
I've added additional kwarg to
UIA.kwargsFromSuperwhich allows to disable this check for a particular control and disabled it forBrokenCommctrl5Item. While at it I've also made error logged when we cannot get UIA element for these tree view items an error rather than debugWarning to make debugging such issues easier in the future.Testing performed:
Ensured that tree view items in HTML help are once again readable.
Known issues with pull request:
None known
Change log entry:
None needed - this bug is not in a release yet.