Work around VS Code specific performance issues#11657
Merged
Merged
Conversation
See test results for failed build of commit 7d0491fb15 |
Contributor
|
Despite it being a (very) late inclusion, we'll include this in 2020.3.
|
michaelDCurran
previously approved these changes
Sep 23, 2020
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
I support this being included in 2020.3.
Member
|
Approval pending those flake8 errors being addressed of course :)
|
[skip ci]
feerrenrut
approved these changes
Sep 23, 2020
Contributor
|
Thanks @LeonarddeR |
Contributor
|
@LeonarddeR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, I filed this against beta as I feel that this issue has impact for many developers and therefore deserves urgency. Furthermore, the impact outside code is zero.
Link to issue number:
Fixes #11533
Replaces #11653
Summary of the issue:
Visual Studio Code can be very sluggish. The reason is that the root of the Electron application has a tree interceptor that only contains an application, and therefore is basically doing nothing. However, when NVDA receives an event inside Visual Studio Code, it tries to find the tree interceptor assigned to the event's object. It also queries the unused tree interceptor, which is very costly.
Description of how this pull request fixes the issue:
Reintroduced appmodules as suggested by #11653 (comment) .
Testing performed:
Tested that performance increased significantly in both code and code insiders.
Known issues with pull request:
Change log entry: