Fix title cancellation#11631
Merged
Merged
Conversation
Despite unit test logging being hardcoded to False, it appeared that these messages were showing in the log. This was caused by the extra frame before the log call.
In this case the speech is triggered by a tree interceptor (see event_treeInterceptor_gainFocus in source/browseMode.py) which calls speech.speakObject(self.rootNVDAObject ....), and even thought self.rootNVDAObject may refer to the same object, it may not be exactly the same instance.
michaelDCurran
previously approved these changes
Sep 21, 2020
[skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11397
Summary of the issue:
When changing tabs in firefox, the title of the tab was no longer announced.
This was a little confusing because the document seems to have focus, and thus it should still be announced.
Description of how this pull request fixes the issue:
The reason this speech was being cancelled was that the focused object was not the same instance, despite pointing to the same underlying object (the document). This is due to the interceptor having a cache of this object and intercepting the event.
Testing performed:
Steps in #11397
Known issues with pull request:
Change log entry:
Bug fixes: