Support auto complete IntelliSense in SSMS and Visual Studio 2017#11421
Merged
Conversation
feerrenrut
reviewed
Aug 12, 2020
feerrenrut
reviewed
Aug 13, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
I'm ok with this for NVDA 2020.4
I'll merge this once we branch off for the 2020.3 beta.
feerrenrut
previously approved these changes
Aug 13, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
I meant to approve, same comment:
I'm ok with this for NVDA 2020.4
I'll merge this once we branch off for the 2020.3 beta.
feerrenrut
approved these changes
Sep 11, 2020
Collaborator
Author
|
It turns out that this pr yet touches some areas of Visual Studio 2019. Accessibility implementations are differing when using C++ or C# code, which is pretty confusing. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #7504
Summary of the issue:
In Microsoft SQL Server Management Studio, IntelliSense does not work.
Description of how this pull request fixes the issue:
I implemented support for IntelliSense using the UIA Element Selected event. In the past this was very slow, but with selective UIA event registration enabled, this works pretty nice. Having said that, even without selective registration enabled it at least reads results, though with somewhat more delay.
Testing performed:
Tested auto complete IntelliSense in SSMS 18. SSMS 18 has the same Accessibility backend as Visual Studio 2017, so it should also work there. I'm not sure whether VS2017 is still used somewhere though, probably in some corporate environments.
I can also provide an implementation based on an app module.
Known issues with pull request:
Not tested with Visual Studio 2017. May be @Luke-Robinett is interested? Otherwise we can also consider making this SSMS specific.
Change log entry: