Speech Dictionary - UI - Regex: Early detect grouping errors (#11407)#11409
Merged
feerrenrut merged 3 commits intoSep 18, 2020
Conversation
Contributor
|
Could you please enable "Allow edits from maintainers" on this PR? It allows us to update the change log and merge all in one. |
Contributor
Author
|
@feerrenrut wrote:
I'm afraid this seems to work only with forks owned by individuals. See isaacs/github#1681. |
Contributor
Ah thanks for letting me know, I didn't realize that! |
feerrenrut
previously approved these changes
Sep 18, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks @JulienCochuyt
feerrenrut
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11407
Summary of the issue:
When editing Speech Dictionary entries, regex compilation errors are reported on the fly.
Some grouping errors arise only when actually attempting substitution, leading to the deletion of the faulty entry without prompting the user for a correction.
Description of how this pull request fixes the issue:
Upon editing a regex entry, not only compile it, but also attempt substitution.
Testing performed:
Ensured the error test case in #11407 is properly detected upon submitting the entry.
Known issues with pull request:
Change log entry:
Section: Bug fixes
More regular expression errors are now detected when editing Speech Dictionary entries.