Skip to content

I8438 fix ordered list start number in ie#11346

Merged
feerrenrut merged 7 commits into
masterfrom
i8438-fixOrderedListStartNumberInIE
Jul 13, 2020
Merged

I8438 fix ordered list start number in ie#11346
feerrenrut merged 7 commits into
masterfrom
i8438-fixOrderedListStartNumberInIE

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

Link to issue number:

handles review actions for (and supersedes) #8474
fixes #8438

Summary of the issue:

  1. In IE NVDA was not reading list item numbers for ordered list if the number is specified in start attribute.
  2. NVDA also does not handle the type attribute that specifies what type of numbers should be shown.

Example:

<ol start="50">
  <li>Coffee</li>
  <li>items<ol type="A">
  	<li>thing</li>
  	<li>another thing</li>
  </ol></li>
  <li>Tea</li>
  <li>Milk</li>
</ol>

Description of how this pull request fixes the issue:

  • The start attribute is now observed for IE, fixing the first issue.
  • The second issue is not considered as important, since the ordering information is announced, I.E. a number is read instead of the letter, or roman numeral. This is essentially a presentation issue, and matches what happens for unordered lists where "bullet" is read regardless of the level or bullet type.

Testing performed:

In IE I explored ordered lists, unordered lists, combinations, with and without the start and type attribute

Known issues with pull request:

None

Change log entry:

Bug fixes
In Internet Explorer, numbers are now announced correctly for ordered lists if the list does not start with 1. (#8438)

Comment thread nvdaHelper/vbufBackends/mshtml/mshtml.cpp Outdated
@feerrenrut feerrenrut merged commit 41b6f7e into master Jul 13, 2020
@feerrenrut feerrenrut deleted the i8438-fixOrderedListStartNumberInIE branch July 13, 2020 17:39
@nvaccessAuto nvaccessAuto added this to the 2020.3 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ordered list numbering always starts from number 1 without regard to type or start attribute in internet explorer

4 participants