Open With: treat Shell-Flyout as a good UIA window#11336
Merged
Conversation
…s first added in 2011 as a temporary workaround for Open With issue in Windows 8 preview. Re nvaccess#11335
…ccess#11335. ON some systems running Windows 10 May 2020 UPdate (Version 2004), Open With dialog was not read, although NVDA will say 'pane'. Turns out this is a UIA element that is seen as an IAccessible by NVDA. Thus classify Sheell_Flyout window as a good UIA window. NOt only does this let NVDA announce Open With dialog in May 2020 Update, it also lets nVDA not announce 'pane' when Open With opens.
|
Remember windows 7 users though. Microsoft still seems interested in
supporting us, forcing edge onto my windows 7 last week.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Sunday, July 05, 2020 9:04 AM
Subject: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA window
(#11336)
… ### Link to issue number:
Closes #11335
### Summary of the issue:
IN Windows 10 May 2020 Update, Open With dialog content is not announced
on some systems.
### Description of how this pull request fixes the issue:
Treat Shell_Flyout window as a good UIA window as far as Open With dialog
is concerned. Not only this resolves the mentioned issue, it will now let
NVDA not nanounce "pane" when Open With opens. Also updated
copyright header (the app module file was actually added in 2011 to
provide a temporary workaround for Open With window in Windows 8 preview).
### Testing performed:
Tested via Windows 10 App Essentials add-on:
* Reading Open With window on all Windows releases since Windows 8.1: yes,
reads dialog content.
* Reads Open With dialog in May 2020 Update: yes, reads dialog content.
### Known issues with pull request:
None
### Change log entry:
If one is to be provided:
Bug fixes: NVDA will announce Open With dialog content in Windows 10 May
2020 Update. (#11300
### Additional considerations on app module content:
With the introduction of isGoodUIAWindow method in app modules, it might
be tempting to go with this approach all the way - that is, remove overlay
class chooser. Testing shows that it is okay to remove
chooseNVDAObjectOverlayClasses for Open With app module for this
particular case, but there might be times when overlay classes defined in
this app module are needed. Therefore I propose revisiting the state of
Open With app accessibility on Windows 8.1 and later before doing
additoinal work on this app module after the pull request (perhaps
deprecate this app module altogether).
Thanks.
You can view, comment on, or merge this pull request online at:
#11336
-- Commit Summary --
* appModules/Open With: copyright header update (note that this file was
first added in 2011 as a temporary workaround for Open With issue in
Windows 8 preview. Re #11335
* appModules/open with: treat Shell_Flyout as a good UIA window. Re
#11335.
-- File Changes --
M source/appModules/openwith.py (16)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/11336.patch
https://github.com/nvaccess/nvda/pull/11336.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#11336
|
Contributor
Author
|
Hi, this doesn’t apply to Windows 7 as Open With is specific to Windows 8 and later. Thanks.
From: Brian Gaff <notifications@github.com>
Sent: Sunday, July 5, 2020 2:28 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA window (#11336)
Remember windows 7 users though. Microsoft still seems interested in
supporting us, forcing edge onto my windows 7 last week.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Sunday, July 05, 2020 9:04 AM
Subject: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA window
(#11336)
### Link to issue number:
Closes #11335
### Summary of the issue:
IN Windows 10 May 2020 Update, Open With dialog content is not announced
on some systems.
### Description of how this pull request fixes the issue:
Treat Shell_Flyout window as a good UIA window as far as Open With dialog
is concerned. Not only this resolves the mentioned issue, it will now let
NVDA not nanounce "pane" when Open With opens. Also updated
copyright header (the app module file was actually added in 2011 to
provide a temporary workaround for Open With window in Windows 8 preview).
### Testing performed:
Tested via Windows 10 App Essentials add-on:
* Reading Open With window on all Windows releases since Windows 8.1: yes,
reads dialog content.
* Reads Open With dialog in May 2020 Update: yes, reads dialog content.
### Known issues with pull request:
None
### Change log entry:
If one is to be provided:
Bug fixes: NVDA will announce Open With dialog content in Windows 10 May
2020 Update. (#11300
### Additional considerations on app module content:
With the introduction of isGoodUIAWindow method in app modules, it might
be tempting to go with this approach all the way - that is, remove overlay
class chooser. Testing shows that it is okay to remove
chooseNVDAObjectOverlayClasses for Open With app module for this
particular case, but there might be times when overlay classes defined in
this app module are needed. Therefore I propose revisiting the state of
Open With app accessibility on Windows 8.1 and later before doing
additoinal work on this app module after the pull request (perhaps
deprecate this app module altogether).
Thanks.
You can view, comment on, or merge this pull request online at:
#11336
-- Commit Summary --
* appModules/Open With: copyright header update (note that this file was
first added in 2011 as a temporary workaround for Open With issue in
Windows 8 preview. Re #11335
* appModules/open with: treat Shell_Flyout as a good UIA window. Re
#11335.
-- File Changes --
M source/appModules/openwith.py (16)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/11336.patch
https://github.com/nvaccess/nvda/pull/11336.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#11336
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#11336 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEC3CC2Q5PH5ZLBQMM3R2BBRVANCNFSM4OQYILSA> .
|
|
We do have an open with in the context menu.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Brian Gaff" <bglists@blueyonder.co.uk>; "Comment"
<comment@noreply.github.com>
Sent: Sunday, July 05, 2020 5:41 PM
Subject: Re: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA
window (#11336)
Hi, this doesn’t apply to Windows 7 as Open With is specific to Windows 8
and later. Thanks.
From: Brian Gaff <notifications@github.com>
Sent: Sunday, July 5, 2020 2:28 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author
<author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA
window (#11336)
Remember windows 7 users though. Microsoft still seems interested in
supporting us, forcing edge onto my windows 7 last week.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Sunday, July 05, 2020 9:04 AM
Subject: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA window
(#11336)
### Link to issue number:
Closes #11335
### Summary of the issue:
IN Windows 10 May 2020 Update, Open With dialog content is not announced
on some systems.
### Description of how this pull request fixes the issue:
Treat Shell_Flyout window as a good UIA window as far as Open With dialog
is concerned. Not only this resolves the mentioned issue, it will now let
NVDA not nanounce "pane" when Open With opens. Also updated
copyright header (the app module file was actually added in 2011 to
provide a temporary workaround for Open With window in Windows 8 preview).
### Testing performed:
Tested via Windows 10 App Essentials add-on:
* Reading Open With window on all Windows releases since Windows 8.1: yes,
reads dialog content.
* Reads Open With dialog in May 2020 Update: yes, reads dialog content.
### Known issues with pull request:
None
### Change log entry:
If one is to be provided:
Bug fixes: NVDA will announce Open With dialog content in Windows 10 May
2020 Update. (#11300
### Additional considerations on app module content:
With the introduction of isGoodUIAWindow method in app modules, it might
be tempting to go with this approach all the way - that is, remove overlay
class chooser. Testing shows that it is okay to remove
chooseNVDAObjectOverlayClasses for Open With app module for this
particular case, but there might be times when overlay classes defined in
this app module are needed. Therefore I propose revisiting the state of
Open With app accessibility on Windows 8.1 and later before doing
additoinal work on this app module after the pull request (perhaps
deprecate this app module altogether).
Thanks.
You can view, comment on, or merge this pull request online at:
#11336
-- Commit Summary --
* appModules/Open With: copyright header update (note that this file was
first added in 2011 as a temporary workaround for Open With issue in
Windows 8 preview. Re #11335
* appModules/open with: treat Shell_Flyout as a good UIA window. Re
#11335.
-- File Changes --
M source/appModules/openwith.py (16)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/11336.patch
https://github.com/nvaccess/nvda/pull/11336.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#11336
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11336 (comment)> , or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4AXEC3CC2Q5PH5ZLBQMM3R2BBRVANCNFSM4OQYILSA>
.
…--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#11336 (comment)
|
Contributor
Author
|
Hi, even then, it isn’t really applicable to Windows 7 as the user interface for the dialog that appears afterward is different. Thanks.
From: Brian Gaff <notifications@github.com>
Sent: Sunday, July 5, 2020 1:44 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA window (#11336)
We do have an open with in the context menu.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Brian Gaff" <bglists@blueyonder.co.uk>; "Comment"
<comment@noreply.github.com>
Sent: Sunday, July 05, 2020 5:41 PM
Subject: Re: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA
window (#11336)
Hi, this doesn’t apply to Windows 7 as Open With is specific to Windows 8
and later. Thanks.
From: Brian Gaff <notifications@github.com>
Sent: Sunday, July 5, 2020 2:28 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author
<author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA
window (#11336)
Remember windows 7 users though. Microsoft still seems interested in
supporting us, forcing edge onto my windows 7 last week.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Sunday, July 05, 2020 9:04 AM
Subject: [nvaccess/nvda] Open With: treat Shell-Flyout as a good UIA window
(#11336)
### Link to issue number:
Closes #11335
### Summary of the issue:
IN Windows 10 May 2020 Update, Open With dialog content is not announced
on some systems.
### Description of how this pull request fixes the issue:
Treat Shell_Flyout window as a good UIA window as far as Open With dialog
is concerned. Not only this resolves the mentioned issue, it will now let
NVDA not nanounce "pane" when Open With opens. Also updated
copyright header (the app module file was actually added in 2011 to
provide a temporary workaround for Open With window in Windows 8 preview).
### Testing performed:
Tested via Windows 10 App Essentials add-on:
* Reading Open With window on all Windows releases since Windows 8.1: yes,
reads dialog content.
* Reads Open With dialog in May 2020 Update: yes, reads dialog content.
### Known issues with pull request:
None
### Change log entry:
If one is to be provided:
Bug fixes: NVDA will announce Open With dialog content in Windows 10 May
2020 Update. (#11300
### Additional considerations on app module content:
With the introduction of isGoodUIAWindow method in app modules, it might
be tempting to go with this approach all the way - that is, remove overlay
class chooser. Testing shows that it is okay to remove
chooseNVDAObjectOverlayClasses for Open With app module for this
particular case, but there might be times when overlay classes defined in
this app module are needed. Therefore I propose revisiting the state of
Open With app accessibility on Windows 8.1 and later before doing
additoinal work on this app module after the pull request (perhaps
deprecate this app module altogether).
Thanks.
You can view, comment on, or merge this pull request online at:
#11336
-- Commit Summary --
* appModules/Open With: copyright header update (note that this file was
first added in 2011 as a temporary workaround for Open With issue in
Windows 8 preview. Re #11335
* appModules/open with: treat Shell_Flyout as a good UIA window. Re
#11335.
-- File Changes --
M source/appModules/openwith.py (16)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/11336.patch
https://github.com/nvaccess/nvda/pull/11336.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#11336
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11336 (comment)> , or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4AXEC3CC2Q5PH5ZLBQMM3R2BBRVANCNFSM4OQYILSA>
.
…--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#11336 (comment)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#11336 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXED2GLHWQCMMVPGFJ5DR2DQXZANCNFSM4OQYILSA> .
|
michaelDCurran
approved these changes
Jul 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #11335
Summary of the issue:
IN Windows 10 May 2020 Update, Open With dialog content is not announced on some systems.
Description of how this pull request fixes the issue:
Treat Shell_Flyout window as a good UIA window as far as Open With dialog is concerned. Not only this resolves the mentioned issue, it will now let NVDA not announce "pane" when Open With opens. Also updated copyright header (the app module file was actually added in 2011 to provide a temporary workaround for Open With window in Windows 8 preview).
Testing performed:
Tested via Windows 10 App Essentials add-on and via NVDA source code directly:
Known issues with pull request:
None
Change log entry:
If one is to be provided:
Bug fixes: NVDA will announce Open With dialog content in Windows 10 May 2020 Update. (#11300
Additional considerations on app module content:
With the introduction of isGoodUIAWindow method in app modules, it might be tempting to go with this approach all the way - that is, remove overlay class chooser. Testing shows that it is okay to remove chooseNVDAObjectOverlayClasses for Open With app module for this particular case, but there might be times when overlay classes defined in this app module are needed. Therefore I propose revisiting the state of Open With app accessibility on Windows 8.1 and later before doing additional work on this app module after the pull request (perhaps deprecate this app module altogether).
Thanks.