Fix: NVDA remains silent when deleting a word with control+delete (#3298, #11029)#11315
Merged
Merged
Conversation
feerrenrut
approved these changes
Jun 29, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks @JulienCochuyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #3298
Fixes #11029
Summary of the issue:
As summarized by @bhavyashah in #3298 (comment):
Description of how this pull request fixes the issue:
NVDA now announces the word present at the immediate right of the deleted word when
control+deleteis pressed.Testing performed:
Deleted by characters and by words in various editors including Notepad, Microsoft Word and HTML forms with Google Chrome.
Known issues with pull request:
As mentioned in various comments in both #3298 and #11029, some might have expected the deleted word should be announced, just like with
control+backspace.However, for consistency with
backspacevsdelete, I took here the path described by @bhavyashah in #3298 (comment):Of course, you're welcome to criticize this decision.
Also, I did not lint the whole of the reused code and kept the legacy gesture binding pattern in order to reduce the diff and ease review. Please tell if you prefer otherwise.
Change log entry:
Section: Bug fixes
When deleting a word with
control+delete, NVDA no longer remains silent. It now announces the word present at the immediate right of the deleted word.