Skip to content

Fix: NVDA remains silent when deleting a word with control+delete (#3298, #11029)#11315

Merged
feerrenrut merged 1 commit into
nvaccess:masterfrom
accessolutions:i11029-controlDelete
Jun 29, 2020
Merged

Fix: NVDA remains silent when deleting a word with control+delete (#3298, #11029)#11315
feerrenrut merged 1 commit into
nvaccess:masterfrom
accessolutions:i11029-controlDelete

Conversation

@JulienCochuyt

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #3298
Fixes #11029

Summary of the issue:

As summarized by @bhavyashah in #3298 (comment):

  • Backspace erases the character at the left of the system caret and NVDA reports the erased character.
  • Delete erases the character at the right of the system caret and NVDA reports the character to the immediate right of the deleted character.
  • Ctrl+Backspace deletes the word at the left of the system caret and NVDA reports the erased word.
  • However, the bug is that when Ctrl+Delete is pressed, and it erases the word to the right of the system caret, NVDA remains silent. A user would ideally expect to hear the word present at the immediate right of the deleted word when Ctrl+Delete is pressed for consistency as well as functionality.

Description of how this pull request fixes the issue:

NVDA now announces the word present at the immediate right of the deleted word when control+delete is pressed.

Testing performed:

Deleted by characters and by words in various editors including Notepad, Microsoft Word and HTML forms with Google Chrome.

Known issues with pull request:

As mentioned in various comments in both #3298 and #11029, some might have expected the deleted word should be announced, just like with control+backspace.
However, for consistency with backspace vs delete, I took here the path described by @bhavyashah in #3298 (comment):
Of course, you're welcome to criticize this decision.

Also, I did not lint the whole of the reused code and kept the legacy gesture binding pattern in order to reduce the diff and ease review. Please tell if you prefer otherwise.

Change log entry:

Section: Bug fixes

When deleting a word with control+delete, NVDA no longer remains silent. It now announces the word present at the immediate right of the deleted word.

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feerrenrut feerrenrut merged commit 6636d78 into nvaccess:master Jun 29, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.2 milestone Jun 29, 2020
@feerrenrut feerrenrut modified the milestones: 2020.2, 2020.3 Jun 29, 2020
@JulienCochuyt JulienCochuyt deleted the i11029-controlDelete branch June 29, 2020 19:24
feerrenrut added a commit that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control+Delete doesn't report the word being deleted Reporting deletes when done using CTRL+DELETE

3 participants