Touch interaction: Add a global command to toggle support (Follow-up of #10557)#11297
Conversation
josephsl
left a comment
There was a problem hiding this comment.
Er, I'm a new user of NVDA. Is NVDA+Shift+T listed in commands quick reference?
|
Hi, Also, when I do git diff between this branch and origin/master, I get submodule commits. Thanks. |
|
@josephsl wrote:
I'm sorry but I can't find any. |
|
@josephsl wrote:
You're definitely right. |
|
Hi, yep, they are in sync. Thanks.
|
|
this shortcut conflicts with the instant translate layer. |
|
@LeonarddeR wrote:
IMO this should not be assigned by default. It is useful only for a tiny minority of users. |
|
Agreed there.
|
feerrenrut
left a comment
There was a problem hiding this comment.
Can you please add the gesture to the userguide. Under the "Enable touch interaction support" section.
|
@LeonarddeR wrote:
This add-on indeed binds @lukaszgo1 wrote:
I agree there are probably currently more user interested in translation oriented add-ons than they are in this global command. Hence, I'd propose |
|
@josephsl wrote:
@feerrenrut wrote:
Both done as of 7eccadb By the way, we might consider adding more of the default touch gestures to the Commands Quick Reference document, as well as finding some way to move the NVDA Touch Gestures section further down the document. |
|
Hi, does anyone object to assigning Alt+NVDA+T to toggle touch interaction from everywhere? If not, I’ll take a look at this PR this weekend. Thanks.
|
|
nvda+alt+t is already used by the addon time zoner |
|
how about ctrl+alt+nvda+t? Imo we should discuss if it does not maybe make sense to introduce a second layer for addon? i.e. pressing nvda+alt+spacebar activates the second layer and after that one key stroke will be processed. The second layer could be only dedicated to scripts and commands introduced by addons. The first layer is reserved only for commands in the NVDA core. |
|
Otherwise at a certain point we will end in a situation where you need more than 5 fingers to execute a command :)) |
|
@JulienCochuyt wrote:
While the fact that touch screens are getting more and more popular cannot be argued with what makes this command not very interesting for many people is the fact that even on a touch screen pc it adds value only for partially sighted users.
Sounds reasonable. |
|
I agree there are probably currently more user interested in translation oriented add-ons than they are in this global command.
Still, we can reasonably expect touch interaction to become more of a wider concern in the future, as it seems modern user interfaces keep on
evolving this way. (Sure, I miss old text terminals...)
While the fact that touch screens are getting more and more popular cannot be argued with what makes this command not very interesting for many people is
the fact that even on a touch screen pc it adds value only for partially sighted users.
Hence, I'd propose nvda+alt+t, unless off course a contrary consensus arises.
If its use case is that limited, why not make the default gesture be something
more obscure, like NVDA+Alt+Ctrl+T, or NVDA+Ctrl+Windows+T.
Using NVDA+Alt+T, keeps that three finger command from being used in the future
for something more useful to more people, thus forcing something more useful on
to a more unwieldy gesture.
We should not just default to the next available most simple gesture, but should
consider how likely most people are to want it there, especially in the light of
gesture needs of the future.
|
|
@lukaszgo1 wrote:
A blind user might also benefit from this feature in the case of a full screen UI with a usable native touch interface. @XLTechie wrote:
Agreed.
My preference, if we decide for a 4-fingers gesture, would go for
|
feerrenrut
left a comment
There was a problem hiding this comment.
Thanks @JulienCochuyt overall this looks good, a minor wording suggestion. Though it would also be good to get feedback from @Qchristensen
|
|
||
| @script( | ||
| # Translators: Describes a command. | ||
| description=_("Toggles on and off the support of touch interaction"), |
There was a problem hiding this comment.
I think this could just be "Toggles support for touch interaction"
| Therefore, actions that can be performed normally without NVDA will not work. | ||
| You can change this by enabling or disabling [touch interaction support # TouchSupportEnable] from touch interaction category of the NVDA settings. | ||
| %kc:beginInclude | ||
| To toggle touch interaction support on and off, press NVDA+alt+t. |
There was a problem hiding this comment.
If you change the script description, don't forget to change this one.
|
@Qchristensen, waiting for your feedback please regarding wording in the documentation. @feerrenrut, what do you think regarding the debate on the default gesture? Shall we go for |
|
I agree with Reef's suggestion re changing the wording in globalCommands.py from "Toggles on and off the support of touch interaction" to "Toggles support for touch interaction". Otherwise, wording all looks good. |
feerrenrut
left a comment
There was a problem hiding this comment.
I think this shortcut is fine. Thanks for your work on this @JulienCochuyt
Shortcut is documented in the userguide
Link to issue number:
Follow-up of PR #10557
Summary of the issue:
Support of touch interaction can now be disabled thanks to PR #10557.
#10557 (comment) proposed the addition of a dedicated gesture to toggle this setting.
Description of how this pull request fixes the issue:
Add a global command, bound to
kb:NVDA+shift+tto toggle touch interaction.Testing performed:
Known issues with pull request:
As mentioned in #10557 (comment), toggling on the touch interaction support can only be achieved through keyboard or braille gestures.
Change log entry:
I guess the change log entry for PR #10557 could be augmented to include the new gesture if it is approved before the release.