Skip to content

Update liblouis to 3.14.0#11221

Merged
feerrenrut merged 2 commits into
nvaccess:masterfrom
AAClause:liblouis3.14
Jun 10, 2020
Merged

Update liblouis to 3.14.0#11221
feerrenrut merged 2 commits into
nvaccess:masterfrom
AAClause:liblouis3.14

Conversation

@AAClause

@AAClause AAClause commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Liblouis 3.14.0 has just been released.

Description of how this pull request fixes the issue:

  1. Updates the liblouis submodule.
  2. Changes the readme.
  3. Adds the following tables: Uzbek grade 1, Israeli grade 1, Israeli 8 dot computer braille and Malay grade 2.

Testing performed:

Tested from source.

Known issues with pull request:

None

Change log entry:

  • Changes
    • Updated liblouis braille translator to 3.14.0 (from 3.13.0).

@zstanecic

zstanecic commented Jun 2, 2020 via email •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

@zstanecic

zstanecic commented Jun 2, 2020 via email •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

@AAClause

AAClause commented Jun 2, 2020

Copy link
Copy Markdown
Contributor Author

@zstanecic It's already done. Please read the PR description/the diff.

@codeofdusk

codeofdusk commented Jun 4, 2020

Copy link
Copy Markdown
Contributor

Are there plans to get this into 2020.2?

@codeofdusk

codeofdusk commented Jun 4, 2020

Copy link
Copy Markdown
Contributor

If you do, you'll want to change the changelog entry to:

Updated liblouis braille translator to 3.14.0 (from 3.12.0).

@zstanecic

zstanecic commented Jun 4, 2020 via email •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

@zstanecic

zstanecic commented Jun 4, 2020 via email •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

@feerrenrut feerrenrut added component/braille component/liblouis Issues related to liblouis, such as liblouis updates and braille table additions/changes maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates. labels Jun 9, 2020
@dpy013

dpy013 commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

hello
Will this pr be merged into NVDA 2020.2?
thanks

@zstanecic

zstanecic commented Jun 9, 2020 via email •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

@dpy013

dpy013 commented Jun 9, 2020 •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

@feerrenrut
Any suggestions?
thanks

@feerrenrut

feerrenrut commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

@LeonarddeR can you comment on how reliable/stable liblouis releases have been historically?

@LeonarddeR

LeonarddeR commented Jun 9, 2020

Copy link
Copy Markdown
Collaborator

@LeonarddeR can you comment on how reliable/stable liblouis releases have been historically?

I don't recall any sever issues with liblouis release stability, other than the breakage that no longer allowed us to build it with VC++.
Version liblouis 3.14 has only a few source code changes, mostly table improvements as @zstanecic pointed out. It all depends on when you intend to release 2020.2, but if there is at least a period of around 4 weeks before that, I think it is safe to merge.

@zstanecic

zstanecic commented Jun 9, 2020 via email •
edited by feerrenrut
Loading

Copy link
Copy Markdown
Contributor

feerrenrut
feerrenrut approved these changes Jun 10, 2020
View reviewed changes

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @Andre9642

@feerrenrut

feerrenrut commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @LeonarddeR. Given that we haven't started the beta releases yet, this should be plenty of time for this to get adequate testing. I'll merge this in.

@feerrenrut feerrenrut merged commit 87ed54a into nvaccess:master Jun 10, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.2 milestone Jun 10, 2020
@Futyn-Maker

Futyn-Maker commented Jun 17, 2020

Copy link
Copy Markdown

I understand that I've been bit late, but You've forgotten to include the new Ukrainian computer braille table. If it is possible before NVDA 2020.2 release, I'll very glad.

@dpy013

dpy013 commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

I understand that I've been bit late, but You've forgotten to include the new Ukrainian computer braille table. If it is possible before NVDA 2020.2 release, I'll very glad.

liblouis Are there any related forms?

@Futyn-Maker

Futyn-Maker commented Jun 17, 2020

Copy link
Copy Markdown

liblouis Are there any related forms?

I didn't understand Your question, to be honest. The table was included in Liblouis 3.14 and called "uk-comp.utb"

Andrey

@feerrenrut feerrenrut mentioned this pull request Jun 17, 2020
Closed
@AAClause

AAClause commented Jun 17, 2020

Copy link
Copy Markdown
Contributor Author

@Futyn-Maker I'm so sorry for that. :( To add tables, I was only refering to — New, renamed or removed tables — section from the changelog. This table is not listed here.

@AAClause AAClause deleted the liblouis3.14 branch June 17, 2020 14:46
@Futyn-Maker

Futyn-Maker commented Jun 17, 2020

Copy link
Copy Markdown

Yes, it is strange. The note about this table is in "Braille tables improvements"

• New table for Ukrainian computer braille thanks to Andrey Yakuboy and Oleh Shpai.

AAClause added a commit to AAClause/nvda that referenced this pull request Jun 17, 2020
@AAClause
Adds missing braille tables
8f316f1 
See nvaccess#11221 (comment)
Fixes nvaccess#11263
@AAClause AAClause mentioned this pull request Jun 17, 2020
Merged
@josephsl josephsl mentioned this pull request Jun 17, 2020
Closed
@AAClause AAClause mentioned this pull request Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@LeonarddeR LeonarddeR LeonarddeR approved these changes

@feerrenrut feerrenrut feerrenrut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/braille component/liblouis Issues related to liblouis, such as liblouis updates and braille table additions/changes maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates.

Projects

None yet

Milestone

2020.2

Development

Successfully merging this pull request may close these issues.

8 participants

@AAClause @zstanecic @codeofdusk @dpy013 @feerrenrut @LeonarddeR @Futyn-Maker @nvaccessAuto