Avoid reporting systray tool-tips if their text equals the focused systray icon name (#6656)#11176
Conversation
lukaszgo1
left a comment
There was a problem hiding this comment.
I'd be great to generalize this to other buttons in Windows Explorer exhibiting this behavior i.e. names of apps pinned to Taskbar or buttons used to open task view / people on Windows 10. It should be sufficient to check if the object with focus has a role of button and if its text equals this of the tool tip.
|
@lukaszgo1 wrote:
I agree.
I also took care here to maintain the current announcement on mouse hovering. cc @javidominguez, @jcsteh, @feerrenrut, @josephsl (participants to #6656) |
|
I guess a low vision person would move the mouse back and forth to hear the object and would not wait for double announcement. So imo double announcement should be suppressed as well. |
|
@JulienCochuyt wrote:
IMO we should not. Moving mouse to the given control is a explicit action and for a low vision user mouse is a primary input device so he either moves it fast enough not to be concerned with these duplicate announcements, or he is interested in the fact that tool tip appeared. The latter case might also be useful for developers in some cases as a quick way to check if tool tip exists but is not announced by the screen reader as it is a duplicate or not. |
Link to issue number:
Fixes #6656
Summary of the issue:
When navigating the systray using the keyboard and tool-tips reporting is enabled, most systray icon names are double announced as their name is usually equal to the tool-tip text.
Additionally, to avoid focus jumps, NVDA moves the mouse cursor at the top left corner of the screen as soon as a systray control is gains focused as of keyboard navigation.
Description of how this pull request fixes the issue:
In
appModules.explorer:Do not report if:
Report as usual in any other case.
Additionally, do to reset the mouse cursor position to the top left screen corner upon navigating with the keyboard to the systray if the mouse wasn't their in the first place.
Testing performed:
Ensured systray icons tool-tips are still always reported when actually hovered with the mouse.
Ensured other Explorer tool-tips are still reported, whether they appear due to mouse hovering or keyboard navigation.
Ensured the mouse cursor position is not reset upon systray keyboard navigation if the mouse is not over the systray.
Ensured the mouse cursor position is reset upon systray keyboard navigation if the mouse is over the systray and has not voluntarily been moved there.
Known issues with pull request:
Change log entry:
Section: Bug fixes
The tool-tips of the icons in the system tray are no longer reported upon keyboard navigation if their text is equal to the name of the icons, to avoid a double announce.