Allow display to turn off for power saving during say all#11118
Merged
Conversation
This was referenced Jan 24, 2025
seanbudd
pushed a commit
that referenced
this pull request
Feb 16, 2025
Fixes #17649 Partially reverts #11118 Follow up of #10111, #10643, Summary of the issue: On some systems (mine, for example 😉) the screen still locks during a say all even though we reset the system idle timer. We also reset the display timer in the past, but this was reverted in #11118, particularly on request of @btman16 Description of user facing changes Added a new advanced setting that, when enabled, also resets the display timer. Description of development approach Added new helper/wrapper methods to systemUtils Rather than resetting the timer(s) many times during a say all, we now persist the state during say all using the ES_CONTINUOUS flag. This should avoid an edge case where reading a line takes more then a minute and the sleep timer is a minute, in which case the system will still lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#10643 (comment)
Summary of the issue:
When in say all, the screen is forced to stay on even when there are no screen updates. For non-visual use, this seems unnecessary.
Some users may wish to have their screen turn off for power saving reasons.
Description of how this pull request fixes the issue:
No longer provide the
winKernel.ES_DISPLAY_REQUIREDflag toSetThreadExecutionStateTesting performed:
Tested that say all still continues for the original use case in #10643
Known issues with pull request:
If the screen really updates, such as due to cursor movement, this may not make any difference. Therefore difference is only expected when:
Change log entry: