Cleanup: Stop listening for IAccessible reorder events.#11076
Merged
Conversation
The only place we used these was Skype classic, which is dead now and which NVDA already dropped support for.
LeonarddeR
approved these changes
May 1, 2020
Contributor
|
It would be worth also flagging this on the add-ons message board, despite being unlikely to cause a problem it goes against our intention to maintain a stable API until the next planned breakage. |
michaelDCurran
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
The only place we used reorder events in the NVDA process was Skype classic, which is dead now and which NVDA already dropped support for. I doubt this is having much of a real impact, since shouldAcceptEvent dropped them anyway, but it doesn't make sense to listen (and waste CPU cycles) for something we don't use.
Description of how this pull request fixes the issue:
Remove reorder from the win event map and remove code for reorder in shouldAcceptEvent.
Testing performed:
Not really much to test for, but browsed the web a bit just to be sure.
Known issues with pull request:
There might be add-ons which used requestEvent to listen for reorder. However, this is very unlikely. I grepped through all of the add-ons which have repositories on the NV Access server (which should be most of the add-ons on the official site) and didn't find event_reorder in any of them.
Change log entry:
Changes for developers:
- NVDA no longer listens for IAccessible EVENT_OBJECT_REORDER.