JAB: do not treat ActiveDescendentChange event from not focused component as focus gained event (#5989)#11048
Merged
Merged
Conversation
LeonarddeR
reviewed
Apr 23, 2020
…nent as focus gained event (nvaccess#5989)
Contributor
|
@LeonarddeR Could you please review the latest changes here? Without this fix using Gutter in JetBrains IDE's is quite annoying as editor scrolls in the background and NVDA threads this as a focus change. |
LeonarddeR
approved these changes
Jun 3, 2020
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
I think this is ok, though I'm unable to test this myself.
Contributor
|
Will the current PR merge 2020.2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
closes #5989
Summary of the issue:
When a PropertyActiveDescendentChange event is received, nvda transform it into a event_gainFocus event.
The issue is that PropertyActiveDescendentChange can be raised by components (e.g. tree view) that don't have the focus. In that case, a PropertyActiveDescendentChange does not imply that the newly selected tree node has received the focus.
Description of how this pull request fixes the issue:
Treat PropertyActiveDescendentChange event as focus gained event only if event source has focus or it is an ancestor is the focused component.
Testing performed:
it is not voiced by nvda.
Known issues with pull request:
None
Change log entry:
Bug fixes
Do not change focus in Java application when selection is change in not focused tree, table or list. (#5989)