Winamp: NVDA will once again announce shuffle and repeat status#10947
Merged
Conversation
…er module. Re nvaccess#10945. Python 3 defaults to Unicode strings, and without bytes conversion, FindWindowA will fail. Thus call winUser.FindWindow which eventually clals user32.dll::FindWindowW. This resolves shuffle and repeat status announcement.
michaelDCurran
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10945
Summary of the issue:
NVDA does not announce shuffle and repeat status.
Description of how this pull request fixes the issue:
Calls winUser.FindWindow, which eventually calls user32.dll::FindWindowW, as Python 3 wants to work with Unicode strings by default.
Testing performed:
Tested with Winamp 5.66 and 5.8:
Known issues with pull request:
None
Change log entry:
Bug fixes:
In Winamp, NVDA will once again announce toggle status of shuffle and repeat. (#10945)