Update configobj to 5.1.0dev commit f9a265c4#10944
Merged
Merged
Conversation
* Official support for python 3.7 \* Resolve warnings with collections.abc imports
Contributor
|
@josephsl Could you also test the upgrade paths with this change:
|
lukaszgo1
reviewed
Apr 6, 2020
lukaszgo1
left a comment
Contributor
There was a problem hiding this comment.
Commit of ConfigObj in the readme should also be updated.
Contributor
Author
|
Hi, I’ll test this step with NVDA 2018.3, 2019.2.1, and 2019.3.1 (I have installers for these and can create portable copies of them, then “upgrade” them with a launcher I can generate from source).
|
Contributor
Author
|
Commit of ConfigObj in the readme should also be updated.
Hi, I’ll do so once I perform config upgrade tests (thanks for reminding me).
|
Contributor
Author
|
Hi, Config schema upgrade tests were successful:
Thanks. |
feerrenrut
added a commit
that referenced
this pull request
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10939
Summary of the issue:
Current version of configobj used by NVDA produces errors when run from source copy of NVDA with Python warnings set to "error".
Description of how this pull request fixes the issue:
Recent configobj commits include:
* Resolve warnings with collections.abc imports
Testing performed:
Tested with:
Known issues with pull request:
None so far
Change log entry:
Changes for developers:
Updated configobj to 5.1.0dev commit f9a265c4. (#10939)