Skip to content

Add appModule for ESET antivirus gui.#10894

Merged
feerrenrut merged 3 commits into
nvaccess:masterfrom
PaulSVK:master
Mar 30, 2020
Merged

Add appModule for ESET antivirus gui.#10894
feerrenrut merged 3 commits into
nvaccess:masterfrom
PaulSVK:master

Conversation

@PaulSVK

@PaulSVK PaulSVK commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

Link to issue number:

Summary of the issue:

When switching pages in ESET Egui, nothing is read. Popup notifications are not read. On the other hand, some items are read twice when focused.

Description of how this pull request fixes the issue:

Rather simple appModule for egui:

  • "obj.shouldAllowIAccessibleFocusEvent=True" fixes reading pages and notifications.
  • Checks object name and value for duplicates.
  • Object description is used for internal purposes, so there is no point reading it.

Testing performed:

Tested if page content and notifications are read when they open.
General navigation of ESET Egui to see if anything broke.

Known issues with pull request:

Change log entry:

New features:

  • Add appModule for ESET antivirus gui.

Comment thread source/appModules/egui.py Outdated
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit cd0220b0a2

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PaulSVK

@feerrenrut feerrenrut merged commit 3397708 into nvaccess:master Mar 30, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Mar 30, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Mar 30, 2020
feerrenrut added a commit that referenced this pull request Mar 30, 2020
@ondrosik

Copy link
Copy Markdown
Contributor

Should this work on fresh Eset installation? I installed Eset smart security and it simply says unknown when navigating. Using NVDA 2020.RC1. Interestingly, it worked somehwat before system restart, but after restarting, I can navigate the windows just by object nav or text rewiev

Developer info for navigator object:
name: None
role: ROLE_UNKNOWN
roleText: None
states:
isFocusable: False
hasFocus: False
Python object: <NVDAObjects.IAccessible.IAccessible object at 0x042B0510>
Python class mro: (<class 'NVDAObjects.IAccessible.IAccessible'>, <class 'NVDAObjects.window.Window'>, <class 'NVDAObjects.NVDAObject'>, <class 'documentBase.TextContainerObject'>, <class 'baseObject.ScriptableObject'>, <class 'baseObject.AutoPropertyObject'>, <class 'object'>)
description: None
location: None
value: None
appModule: <'egui' (appName 'egui', process ID 11616) at address 7207c10>
appModule.productName: 'ESET Security'
appModule.productVersion: '13.2.15.0'
TextInfo: <class 'NVDAObjects.NVDAObjectTextInfo'>
windowHandle: 592254
windowClassName: 'EsetBaseWindow'
windowControlID: 0
windowStyle: 1442906112
extendedWindowStyle: 0
windowThreadID: 10248
windowText: ''
displayText: exception: cannot unpack non-iterable NoneType object
IAccessibleObject: <POINTER(IAccessible) ptr=0x768c430 at 2ca5df0>
IAccessibleChildID: -1895386213
IAccessible event parameters: windowHandle=592254, objectID=-4, childID=-1895386213
IAccessible accName: exception: (-2147024809, 'The parameter is incorrect.', (None, None, None, 0, None))
IAccessible accRole: exception: (-2147024809, 'The parameter is incorrect.', (None, None, None, 0, None))
IAccessible accState: exception: (-2147024809, 'The parameter is incorrect.', (None, None, None, 0, None))
IAccessible accDescription: exception: (-2147024809, 'The parameter is incorrect.', (None, None, None, 0, None))
IAccessible accValue: exception: (-2147024809, 'The parameter is incorrect.', (None, None, None, 0, None))
DEBUGWARNING - NVDAObjects.IAccessible.IAccessible._get_IAccessibleRole (08:19:52.662) - MainThread (13040):
accRole failed: (-2147024809, 'The parameter is incorrect.', (None, None, None, 0, None))

@Ancientlizard

Copy link
Copy Markdown

Hello!
what needs to be done to make the support work?
in my ESET Security in the latest version, everything is also read as "unknown".
but he reads the vision.
and I cannot move around the window with reading all the settings and changing them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants