sayAll skim reading no longer keeps announcing exiting initial control fields#10878
Merged
Conversation
…ol fields when arrowing out and away from them. * no longer have speech.getTextInfoSpeech handle speakWithoutPauses for sayAll, rather this is done in speakTextInfo. This means that gettextInfoSpeech is now more predictable in its output. * sayAllHandler's nextLine method ensures the _lineReached callback can see the TextInfoState after state for the line being spoken has been applied. Previously it was one line behind. * sayAllHandler's nextLine method manually inserts the _reached callback at the very beginning of the speech sequence, as previously using _prefix on speakTextInfo would place it after initial controlFields were spoken.
feerrenrut
suggested changes
Mar 16, 2020
feerrenrut
approved these changes
Mar 17, 2020
michaelDCurran
added a commit
that referenced
this pull request
Mar 17, 2020
feerrenrut
added a commit
that referenced
this pull request
Apr 20, 2020
PRs #10878 and #10879 addressed some issues with Speech.speak being passed a Generator. Rather than create a list from it, ensure that the generator is not passed in the first place. The typing of several functions is no much more clear, in particular _flattenNestedSequences now no longer implicitly converts generators to lists. However, in all places it is used, generators are explicitly converted to lists. Logging of generator types has been added in several places, enabled via the advanced settings panel 'speech' debug logging category.
feerrenrut
added a commit
that referenced
this pull request
Apr 20, 2020
PRs #10878 and #10879 addressed some issues with Speech.speak being passed a Generator. Rather than create a list from it, ensure that the generator is not passed in the first place. The typing of several functions is no much more clear, in particular _flattenNestedSequences now no longer implicitly converts generators to lists. However, in all places it is used, generators are explicitly converted to lists. Logging of generator types has been added in several places, enabled via the advanced settings panel 'speech' debug logging category.
feerrenrut
added a commit
that referenced
this pull request
Apr 21, 2020
PRs #10878 and #10879 addressed some issues with Speech.speak being passed a Generator. Fixed a bug in speakTextInfo. speakWithoutPauses does not accept a generator as it needs to be able to get the number of items in the sequence and slice it. Rather than create a list from the generator inside Speech.speak, ensure that the generator is not used as an argument in the first place. The typing of several functions has now been clarified, in particular _flattenNestedSequences now no longer implicitly converts generators to lists. However, now all usages of _flattenNestedSequences explicitly convert to lists. Logging of generator types has been added in several places including speakWithoutPauses which needs to be able to get the length of a sequence and slice it. The logging can be enabled via the advanced settings panel 'speech' debug logging category.
This was referenced Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10706
Summary of the issue:
When skim reading in sayAll starting from inside a list or other container, NVDA may keep announcing exiting the list when rapidly arrowing out and away from the container.
This is due to two reasons:
Description of how this pull request fixes the issue:
Testing performed:
Ran through the steps in #10706. Ensured that the initial control fields were only announced the first time and did not continue to be repeated.
Known issues with pull request:
None.
Change log entry:
Bug fixes: