Allow again _FakeTableCell to have no location defined#10868
Merged
michaelDCurran merged 1 commit intoMar 17, 2020
Conversation
Contributor
Author
|
@LeonarddeR Two points may be still pending:
PS: I did not find how t to ask you a review but in this comment. |
LeonarddeR
approved these changes
Mar 11, 2020
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Lets investigate beTransparentToMouse later on.
michaelDCurran
approved these changes
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10864
Summary of the issue:
In NVDA 2019.2.1 it was possible to define behaviors.RowWithoutCellObjects without defining column location. In NVDA 2019.3.1, the code documentation still states that RowWithoutCellObjects._getColumnLocation method is optional, but not implementing it breaks fake table navigation.
Description of how this pull request fixes the issue:
Restore fake table navigation when RowWithoutCellObjects._getColumnLocation is not implemented (overridden)
Alternative
An alternative could have been to document _get_columnLocation as required instead of optional. However, since RowWithoutCellObjects and inherits from NVDAObject which can have location set to None, it seemed important to me that _get_columnLocation remain optional, even if I do not know any case where this method is not implemented.
Testing performed:
Known issues with pull request:
None
Change log entry:
Section: Changes for developers or bugfixes
Allow again behaviors._FakeTableCell to have no location defined (#10864)