ensure NVDA speaks text being unselected in browse mode#10862
Merged
Conversation
…elected in browseMode again. Fixes regression caused by #10389.
See test results for failed build of commit 68a9b5c112 |
feerrenrut
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10731
Summary of the issue:
Since the merging of pr #10389, If text is selected in browse mode, then the an arrow key is pressed such that the selection is canceled and the caret is moved, NVDA no longer announces the text being unselected.
This is because although the original pr moved the speakSelectionChange call above the setting of self.selection, the speakSelectionChange call itself was passed self.selection as a parameter and after the move self.selection was no longer the new textInfo position, and therefore it could not get a correct delta of the new and old selections.
Description of how this pull request fixes the issue:
In the speakSelectionchange call, change self.selection to selection.
Testing performed:
Opened a page in Firefox. In browse mode, select a line with shift+downArrow. NVDA announced the line was selected. Then press downArrow (deselecting that line and moving to the next line). NVDA announced the new line and also announced the original line was unselected.
Known issues with pull request:
None.
Change log entry:
Bug fixes:
NVDA will again announce text being unselected in browse mode if pressing an arrow key while text is selected. (#10731).