Report 'unsupported' when toggling screen layout in Word#10795
Conversation
See test results for failed build of commit 97b3901ead |
LeonarddeR
left a comment
There was a problem hiding this comment.
Please move one instance of this to browseMode.BrowseModeDocumentTreeInterceptor. This ensures that the not supported message will be pronounced when pressing NVDA+V.
While at this, I think we should consider removing the default assignment for this script anyway.
See test results for failed build of commit 8d3876190a |
|
@LeonarddeR wrote:
Any particular reason for doing so? Removing assignments which are there for years is extremely confusing for users IMHO. |
Well, apart from scarcity of gestures, screen layout is a thing specific to virtual bufffers, not just browse mode. In Word, Excel, Edge HTML, there is no support for screen lay out. Note that I'm only saying that I'd consider it, I wouldn't insist on removing the gesture. But, if there would ever be a good candidate for NVDA+v that might be more important than this one, I'd sacrifice it. |
|
@LeonarddeR Done. As for removing assignment, I'll do it if such decision is made. |
feerrenrut
left a comment
There was a problem hiding this comment.
Hi @jakubl7545 overall this looks good.
Please also update the script_toggleScreenLayout in virtualBuffers/__init__.py to use a @script decorator.
It means both implementations are visible in the history (making the override more clear). It also means both functions are using the same mechanism, and helps to move us towards replacing the old approach.
See test results for failed build of commit 2335315a8a |
|
The error says that 'scriptHandler.isScriptWaiting' is imported but unused in virtualBuffers/init.py. However, I see it in refreshBuffer script in that file. @feerrenrut I'm not sure what to do with that. |
hmm, that is an interesting case. This happens because we only send the diff to to flake8, so that PR's don't have to fix the whole file. The diff includes the changed imports, but not the usage. Ah... also, note that the usage is 'scriptHandler.isScriptWaiting' and there is an import for I wouldn't remove it, because other files may depend on it. But we can clean it up a little and mark it as deprecated, to be removed in the future. I'll add a suggestion in the diff. |
|
@feerrenrut Since this PR removes unused imports it'd be great to add it to the 2021.1 milestone to avoid it being forgotten before the release. |
feerrenrut
left a comment
There was a problem hiding this comment.
Looks good thanks @jakubl7545
Link to issue number:
closes #7297
Summary of the issue:
Currently, when user tries to toggle screen layout in MS Word by pressing NVDA+v the letter is passed to the document. This can be confusing for some users who may expect screen layout to be available.
Description of how this pull request fixes the issue:
It adds a script to both Word modules which just speaks the appropriate message.
Testing performed:
In word with browse mode on and UIA support enabled or disabled pressed NVDA+v and noticed the message that this action is not supported.
Known issues with pull request:
None
Change log entry:
None needed.