Discard duplicated value for a Windows Explorer list items when accessed via IAccessible#10750
Merged
Conversation
…cessible. Fix for nvaccess#10620 Fix for nvaccess#2395
feerrenrut
suggested changes
Feb 5, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
There may be differences in behavior for IAccessible on different versions of Windows. Can you please confirm?
feerrenrut
approved these changes
Feb 6, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks @lukaszgo1 that seems like good test coverage. I'll merge in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10620 fixes #2395
Summary of the issue:
Windows Explorer list items repeat name as the value. By default we are accessing it via UIA, and in this case the value was discarded. There are situations, such as NVDA's own open windows where UIA cannot be used (it causes freezes) and in these cases repetitions were annoying.
Description of how this pull request fixes the issue:
Similar to what has been done for UIA value of these items is discarded when accessed via IAccessible
Testing performed:
Tested that when navigating in the list view in open window from add-on manager value of list items is not announced. Tested the same in Windows Explorer with UIA disabled.
Known issues with pull request:
None known
Change log entry:
Section: Bug fixes
When installing add-on from add-ons manager names of files and folders in the browse window are no longer reported twice.