Skip to content

UI Automation in Windows Console: revert for 2019.3#10684

Merged
michaelDCurran merged 11 commits into
nvaccess:betafrom
codeofdusk:revert-cmduia-20193
Jan 14, 2020
Merged

UI Automation in Windows Console: revert for 2019.3#10684
michaelDCurran merged 11 commits into
nvaccess:betafrom
codeofdusk:revert-cmduia-20193

Conversation

@codeofdusk

@codeofdusk codeofdusk commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Completes #10682.

Summary of the issue:

It was decided to revert to legacy console support for 2019.3, but various UI and user guide elements remain from #9771.

Description of how this pull request fixes the issue:

  • The auto config setting is reverted to 2019.2 behavior (i.e. it maps to legacy).
  • The UI is returned to 2019.2 state (i.e. a simple checkbox). We really should move users to UIA once it becomes the default, and users who turn on UIA to experiment during development and then switch back to legacy wouldn’t automatically be upgraded.
  • References to “legacy” consoles removed from UI and user guide.

Testing performed:

Tested an upgrade from NVDA 2019.2.1 (stable) to this PR. Insured that legacy console is used by default and the UIA checkboxes are functional.

Known issues with pull request:

None.

Change log entry:

None needed.

@codeofdusk codeofdusk changed the base branch from master to beta January 14, 2020 02:40
@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 54af3039b9

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 664f1014ad

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 31d53948c5

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit cfbf2d636c

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit eed2b734c3

@codeofdusk
More style, except spacing of binary operators (to preserve consisten…
64a0b5e 
…cy, as fixing this seems out of scope for this PR).
@codeofdusk

codeofdusk commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

Cc @LeonarddeR @michaelDCurran

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 2eaecfc37c

@michaelDCurran

michaelDCurran commented Jan 14, 2020

Copy link
Copy Markdown
Member

the 'and's need to be on the start of the next line to stop the linting issues I think.

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 0cbdf3b736

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 5252086610

@LeonarddeR

LeonarddeR commented Jan 14, 2020

Copy link
Copy Markdown
Collaborator

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 8a4e6562ec

@codeofdusk

codeofdusk commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default.

@codeofdusk

codeofdusk commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default.

It also keeps "auto" as the default config spec setting, allowing users to freely enable/disable UIA console during development and be automatically switched when it becomes the default.

@AppVeyorBot

AppVeyorBot commented Jan 14, 2020

Copy link
Copy Markdown

See test results for failed build of commit 5942d1788e

@michaelDCurran michaelDCurran merged commit 82eeff0 into nvaccess:beta Jan 14, 2020
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jan 14, 2020
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Jan 23, 2020
@codeofdusk
Role back nvaccess#10684.
0d870ac
@codeofdusk codeofdusk mentioned this pull request Jan 23, 2020
Closed
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Apr 8, 2020
@codeofdusk
Roll back nvaccess#10684.
9021452 
This reverts commit 82eeff0.
@codeofdusk codeofdusk mentioned this pull request Apr 8, 2020
Merged
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Apr 8, 2020
@codeofdusk
Revert "UI Automation in Windows Console: revert for 2019.3 (nvaccess…
ea851f7 
…#10684)"

This reverts commit 82eeff0.
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request May 4, 2020
@codeofdusk
Revert "UI Automation in Windows Console: revert for 2019.3 (nvaccess…
c507f71 
…#10684)"

This reverts commit 82eeff0.
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Aug 7, 2020
@codeofdusk
Revert "UI Automation in Windows Console: revert for 2019.3 (nvaccess…
2b5bc83 
…#10684)"

This reverts commit 82eeff0.
@codeofdusk codeofdusk deleted the revert-cmduia-20193 branch October 26, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2019.3

Development

Successfully merging this pull request may close these issues.

5 participants

@codeofdusk @AppVeyorBot @michaelDCurran @LeonarddeR @nvaccessAuto