Update Espeak to Release 1.50#10572
Merged
Merged
Conversation
Collaborator
Was this also the case with master? |
Contributor
Author
No. |
Contributor
|
I assume that we need to check their voice variant files and edit them accordingly. |
Contributor
|
I mean, we need to edit our language variants files, for example, kaukovalta or fast |
|
Does Quincy still work? Since I did that and a few other variants I tend to
use it exclusively.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "zstanecic" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
…Sent: Tuesday, December 03, 2019 2:18 PM
Subject: Re: [nvaccess/nvda] Update Espeak to Release 1.50 (#10572)
I mean, we need to edit our language variants files, for example,
kaukovalta or fast
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#10572 (comment)
|
Contributor
Author
|
This message comes from /src/libespeak-ng/voices.c line 873. It doesn't look like anything in the area has changed recently. I didn't notice any issues with the voices. I think I will merge this to get wider testing. |
Merged
Contributor
|
@feerrenrut In #10581 you've created branch with the same name as the one for this PR differing only in the capitalization of u. As this causes new branch to appear with each pull can one of these be deleted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
espeak-ng/espeak-ng has a new release.
Description of how this pull request fixes the issue:
Update to version 1.50 of espeak-ng
Testing performed:
Built NVDA locally, ran with espeak as the configured synthesizer, tested several voice variants and languages.
Known issues with pull request:
Many lines were printed to my console window:
Change log entry:
Changes:
eSpeak-ng updated to version 1.50