Send typedCharacter events for Braille when using ToUnicodeEx#10570
Merged
Conversation
Contributor
Author
michaelDCurran
requested changes
Dec 3, 2019
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 3e6b3e27bd |
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit b56a23096e |
michaelDCurran
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #10569.
Summary of the issue:
The
toUnicodeExapproach of typed character detection doesn't work for Braille keyboards.Description of how this pull request fixes the issue:
Manually sends typed character events to objects using
toUnicodeExif focused. We must send all keys after they are typed to avoid unintentionally speaking passwords in Windows Console. A newkeyboardHandler.shouldUseToUnicodeExfunction has been added for this detection.Testing performed:
Tested that typed characters are reported from a 5th-generation Freedom Scientific Focus keyboard, and that password reporting works as expected.
Known issues with pull request:
None.
Change log entry:
== Bug fixes ==