Revert "Support for out-of-process iframes in Firefox"#10538
Merged
Conversation
This reverts commit 71475bc.
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 3967884428 |
Contributor
Author
|
Hmm. How do you want me to proceed here? I guess the lint errors here are errors that were already in the existing code before my patch. It doesn't seem to make sense to fix existing lint errors in a revert. |
Member
|
Assuming this was purely a revert pr created from Github, I'll just merge with admin override. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be causing pretty serious performance problems with several tabs open. I guess adding 6 extra cross-proc calls (at minimum) for any object which isn't in the document adds up pretty fast when you have several buffers. I'll have to figure out an alternative approach, but right now, this is unacceptable. Sorry for the churn.
Reverts #9672