Remove scriptHandler.isCurrentScript which is never called#10468
Merged
Conversation
…ed to Python3, is not used in NVDA's codebase, and does not seem to be used by any add-ons.
LeonarddeR
approved these changes
Nov 6, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
For reference, git blame shows that this was introduced in 8738c34
Member
Author
|
Actually it looks like it was in feca2ef which was a few months
earlier. The other commit just seemed to have changed something inside it.
|
Collaborator
|
Yes, you're right, I"m sorry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8677
Summary of the issue:
scriptHandler.isCurrentScript was the only place left where old attribute names remain from Python2. Namely im_self. If this function were called it would fail on Python3.
Description of how this pull request fixes the issue:
Remove scriptHandler.isCurrentScript, as it is never called from NVDA's codebase, and has never been used in an add-on to our best knowledge.
Testing performed:
NVDA still runs. Scripts such as speak current line (pressed, once, twice, 3 times) function correctly.
Known issues with pull request:
There could be an add-on out there in the wild that did use this function. However, many other changes have been made in 2019.3 which would break these add-ons anyway. It will be listed as a change for developers.
Change log entry:
Changes for developers: