Quick nav: Consider tab headers as form fields (#10432)#10438
Conversation
|
hi @JulienCochuyt |
|
@dingpengyu: Fixed. Thanks! |
See test results for failed build of commit 9922a5a315 |
feerrenrut
left a comment
There was a problem hiding this comment.
The changes look fine.
I understand that this PR has been waiting a long time, but I have a small doubt about whether tabs SHOULD be considered form fields. After all you can't enter information with them. I suppose they could be used in place of a radio button, but that seems pretty broken.
I suspect the reason this has been waiting so long is because others are also uncertain, along with the diff being a little hard to follow (due to necessary reformatting).
I'd like to flag this decision, and defer to @michaelDCurran for an opinion about whether this fits.
|
After talking to @michaelDCurran about this, we are happy to go ahead. We also treat buttons as form fields. |
Link to issue number:
Fixes #10432
Summary of the issue:
Tab headers are currently not considered when navigating by form fields.
Description of how this pull request fixes the issue:
Add the tab header roles to those considered as form fields:
Testing performed:
Tested from source on Windows 10 version 1903 (18362.418) with:
Known issues with pull request:
The diff looks bigger only to comply with linting.
Effective changes are really just adding the relevant role in three lists for gecko_ia2, MSHTML and UIA.
Change log entry:
Section: New features or Changes
Tab headers are now considered as form fields when using quick navigation with the letter "f".